Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/quiet-trace-events.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"helm-charts": patch
---

feat: update the default HyperDX sources to match the current source schema (only applies to new installs; existing sources are not modified)

- Traces: set `spanEventsValueExpression: "Events"` and `spanLinksValueExpression: "Links"` so span events (including exceptions) and span links are shown
- Metrics: register the `summary` and `exponential histogram` metric tables
- Remove fields HyperDX ignores for each source kind (e.g. log-style fields on the Sessions source, stray `_id`/`id` keys in `metricTables`)
20 changes: 20 additions & 0 deletions charts/clickstack/tests/default-env-vars_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,26 @@ tests:
content:
name: DEFAULT_CONNECTIONS

- it: should set span events and links on the default trace source
asserts:
- matchRegex:
path: spec.template.spec.containers[0].env[?(@.name == "DEFAULT_SOURCES")].value
pattern: '"kind": "trace",[^}]*"spanEventsValueExpression": "Events"'
- matchRegex:
path: spec.template.spec.containers[0].env[?(@.name == "DEFAULT_SOURCES")].value
pattern: '"kind": "trace",[^}]*"spanLinksValueExpression": "Links"'

# metricTables keys must match MetricsDataType values; unknown keys
# (e.g. camelCase "exponentialHistogram") are silently dropped by HyperDX.
- it: should register all OTel metric tables on the default metric source
asserts:
- matchRegex:
path: spec.template.spec.containers[0].env[?(@.name == "DEFAULT_SOURCES")].value
pattern: '"summary": "otel_metrics_summary"'
- matchRegex:
path: spec.template.spec.containers[0].env[?(@.name == "DEFAULT_SOURCES")].value
pattern: '"exponential histogram": "otel_metrics_exponential_histogram"'

- it: should not include DEFAULT_SOURCES when set to empty string
set:
hyperdx:
Expand Down
25 changes: 6 additions & 19 deletions charts/clickstack/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ hyperdx:
"spanIdExpression": "SpanId",
"connection": "Local ClickHouse",
"traceSourceId": "Traces",
"sessionSourceId": "Sessions",
"metricSourceId": "Metrics"
},
{
Expand All @@ -250,7 +249,6 @@ hyperdx:
"displayedTimestampValueExpression": "Timestamp",
"implicitColumnExpression": "SpanName",
"serviceNameExpression": "ServiceName",
"bodyExpression": "SpanName",
"eventAttributesExpression": "SpanAttributes",
"resourceAttributesExpression": "ResourceAttributes",
"defaultTableSelectExpression": "Timestamp,ServiceName,StatusCode,round(Duration/1e6),SpanName",
Expand All @@ -263,6 +261,8 @@ hyperdx:
"spanKindExpression": "SpanKind",
"statusCodeExpression": "StatusCode",
"statusMessageExpression": "StatusMessage",
"spanEventsValueExpression": "Events",
"spanLinksValueExpression": "Links",
"connection": "Local ClickHouse",
"logSourceId": "Logs",
"sessionSourceId": "Sessions",
Expand All @@ -281,13 +281,11 @@ hyperdx:
"gauge": "otel_metrics_gauge",
"histogram": "otel_metrics_histogram",
"sum": "otel_metrics_sum",
"_id": "682586a8b1f81924e628e808",
"id": "682586a8b1f81924e628e808"
"summary": "otel_metrics_summary",
"exponential histogram": "otel_metrics_exponential_histogram"
},
"connection": "Local ClickHouse",
"logSourceId": "Logs",
"traceSourceId": "Traces",
"sessionSourceId": "Sessions"
"logSourceId": "Logs"
},
{
"from": {
Expand All @@ -297,20 +295,9 @@ hyperdx:
"kind": "session",
"timestampValueExpression": "TimestampTime",
"name": "Sessions",
"displayedTimestampValueExpression": "Timestamp",
"implicitColumnExpression": "Body",
"serviceNameExpression": "ServiceName",
"bodyExpression": "Body",
"eventAttributesExpression": "LogAttributes",
"resourceAttributesExpression": "ResourceAttributes",
"defaultTableSelectExpression": "Timestamp,ServiceName,SeverityText,Body",
"severityTextExpression": "SeverityText",
"traceIdExpression": "TraceId",
"spanIdExpression": "SpanId",
"connection": "Local ClickHouse",
"logSourceId": "Logs",
"traceSourceId": "Traces",
"metricSourceId": "Metrics"
"traceSourceId": "Traces"
}
]

Expand Down
Loading