SDK-5744: Add Five Icon push notification template for iOS#56
Open
reshab-code wants to merge 19 commits into
Open
SDK-5744: Add Five Icon push notification template for iOS#56reshab-code wants to merge 19 commits into
reshab-code wants to merge 19 commits into
Conversation
…nded state for 5 icon template
- Rename template id pt_icon_list → pt_five_icons - Rename CTIconListViewController → CTFiveIconsViewController - Rename CTIconListModel → CTFiveIconsModel - Rename Templates/IconList/ folder → Templates/FiveIcons/ - Remove pt_gif key and all GIF view/layout code from the template - Update Xcode project file references and Obj-C enum/constant names
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Adjusted image spacing and removed aspect ratio constraints. Added fallback to render only the title and message for payloads without images.
Contributor
|
@coderabbitai review |
nishant-clevertap
requested changes
Jun 9, 2026
Contributor
There was a problem hiding this comment.
What should be deeplink when we click on notification area apart from images?
| if done { finish() } | ||
| continue | ||
| } | ||
| SDWebImageManager.shared.loadImage(with: url, options: [.retryFailed], progress: nil) { image, _, _, _, finished, _ in |
Contributor
There was a problem hiding this comment.
why are we using SDWebImageManager?
| } | ||
| } | ||
|
|
||
| DispatchQueue.main.asyncAfter(deadline: .now() + timeout) { finish() } |
Contributor
There was a problem hiding this comment.
this will call finish after timeout if images take more time to load, check this behaviour
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
pt_five_iconspush notification template that displays a horizontal row of up to 5 circular icon images, each with an optional deep link tap target.CTFiveIconsViewControllerandCTFiveIconsModelunderTemplates/FiveIcons/pt_img1–pt_img5) and 5 deep links (pt_dl1–pt_dl5)pt_title) and message (pt_msg) rendered above the icon row