Skip to content

Fix: Update form control focus border and add green box-shadow#258

Merged
Nihal4777 merged 2 commits into
CircuitVerse:masterfrom
ghanshyam2005singh:fix/button-hover-green
May 31, 2026
Merged

Fix: Update form control focus border and add green box-shadow#258
Nihal4777 merged 2 commits into
CircuitVerse:masterfrom
ghanshyam2005singh:fix/button-hover-green

Conversation

@ghanshyam2005singh
Copy link
Copy Markdown
Contributor

@ghanshyam2005singh ghanshyam2005singh commented Dec 24, 2025

Fix: Button Hover & Form Control Focus Colors (Closes #257)

Summary

This PR fixes UI consistency issues to match the CircuitVerse color scheme: Form control focus state - Text input fields now show a green border and subtle green glow on focus instead of red

Changes

File: assets/scss/_mixins.scss

  • Added focus state override for .form-control to use #40ba84 border with a matching green box-shadow
  • No submodule files were modified; all changes are safe from future submodule updates

How to Test

  1. Navigate to the contact page
  2. Click on any text input field
  3. The border should turn green (#40ba84) with a subtle green glow
  4. It should not turn red at any point

Screen Recording

Screencast.from.2025-12-24.14-15-40.webm

Summary by CodeRabbit

  • Style
    • Reformatted theme and responsive styles for spacing and consistency across navigation, blog, pagination, buttons, footer social, and centered links.
    • Refined Table-of-Contents link styling for clearer appearance and hover behavior.
    • Enhanced form control focus states with a stronger green border and subtle glow for improved visual feedback.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 24, 2025

Review Change Stack

Walkthrough

Reformats responsive mixin definitions and multiple CircuitVerse theme override rules for spacing/consistency without changing behaviors, expands and annotates Table-of-Contents link and related media-query blocks, and adds a new focus-state rule for input.form-control and textarea.form-control applying border-color #40ba84 and a 0.2rem green box-shadow.

Changes

Cohort / File(s) Summary
Form Control Focus Styling
assets/scss/_mixins.scss
Introduces input.form-control:focus and textarea.form-control:focus selectors with green border-color (#40ba84) and green box-shadow effect (0.2rem), along with broader SCSS reformatting across responsive mixins, navigation, blogs, pagination, buttons, footer social icons, .text-center links, and TOC styles.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Out of Scope Changes check ❓ Inconclusive The PR includes formatting/spacing changes to responsive mixins and other selectors alongside the main focus-state override, which appear to be incidental refactoring. Clarify whether the extensive reformatting of unrelated selectors is intentional or should be separated into a separate formatting PR for cleaner change isolation.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a green border and box-shadow to form control focus states instead of the default red.
Linked Issues check ✅ Passed The PR directly addresses issue #257 by changing form control focus border color from red to green (#40ba84) with matching box-shadow, matching the expected behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.


Co-authored-by: Priyank <pvonlyone29@gmail.com>
@Nihal4777
Copy link
Copy Markdown
Member

Thanks @ghanshyam2005singh

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
assets/scss/_mixins.scss (1)

33-33: 💤 Low value

Optional: Fix typo in comment.

"Overriden" should be "Overridden" (double 'd').

✏️ Proposed fix
-    // Overriden here
+    // Overridden here

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0fb9ac1c-5150-4ac8-8aea-a11d452d275c

📥 Commits

Reviewing files that changed from the base of the PR and between 8ae0341 and 619fa72.

📒 Files selected for processing (1)
  • assets/scss/_mixins.scss

@Nihal4777 Nihal4777 merged commit db1546d into CircuitVerse:master May 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI bug : Change focus border color on Contact Us form from red to green

2 participants