Support CSV and .xlsm inputs in generator and add CSV parsing/tests - #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
.csvand.xlsm) so tables can be authored as CSV or macro-enabled workbooks and processed by the same pipeline.Description
.xlsmand.csvinput support and add the new patterns to exampledotnet dtgeninvocations and README text.IsSupportedInputFileand restrict file enumeration to formats the generator actually supports (.xlsx,.xlsm,.csv).CreateWorkbook,GetCsvSheetName, andReadCsvRowsto map a CSV file into a single in-memoryXSSFWorkbookworksheet and reuse the existing workbook parsing logic.new XSSFWorkbook(stream)usage with a call toCreateWorkbookinGenerateExcel, and addInputFormatGenerationTestsunit tests covering CSV and.xlsminputs.Testing
InputFormatGenerationTests.CsvInput_ShouldGenerateCodeAndDatawhich created a CSV, invoked the generator, and asserted generatedDRItem.csandDRItem.bytes, and the test passed.InputFormatGenerationTests.XlsmInput_ShouldGenerateCodeAndDatawhich created an.xlsmworkbook, invoked the generator, and asserted generatedDRItem.csandDRItem.bytes, and the test passed.Codex Task