feat(providers): allow a NyxID-managed LinkedIn OAuth app - #1771
Merged
Merged
Conversation
LinkedIn was in the startup migration that forces seeded social providers
back to credential_mode "user", so an admin-provisioned shared app
("both"/"admin") reverted on every restart. Exclude it, matching Twitter:
the seed stays BYO-only and ops opt in by setting the provider's client
credentials and mode.
Add a platform scope allowlist for the shared LinkedIn app covering the
products it currently holds (OIDC and Share on LinkedIn). Page, ads and
hiring scopes still require a BYO app until those products are approved.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
📊 Code coverage
Gate: line coverage must stay at or above the threshold. Ratchet plan (W21): Backend → 55%, CLI → 50%, Frontend → 30% by quarter end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linkedinfromSEEDED_USER_CREDENTIAL_OAUTH_PROVIDER_SLUGS, so an admin-provisioned shared LinkedIn app (credential_modeboth/admin) is no longer reset touseron every startup. This matches Twitter: the seed stays BYO-only and ops opt in.platform_scope_allowlistentry forlinkedin(openid profile email w_member_social), the products the shared app currently has (OIDC and Share on LinkedIn). Page, ads and hiring scopes are rejected on the shared app and still need a BYO app until LinkedIn approves those products.Admin setup after deploy
Providers → Manage Providers → LinkedIn → Edit: set Credential Mode to Admin or User, enter the client ID and secret, and set the default scopes to
openid profile email w_member_social. The LinkedIn app must list{BASE_URL}/api/v1/providers/callbackas an authorized redirect URL.Test plan
cargo fmt --all -- --checkscope_catalog::tests::linkedin_platform_allowlist_matches_approved_products(new)seed_does_not_revert_ops_patched_both, now coveringlinkedinseed_keeps_google_github_both_across_restartsand the existing platform allowlist tests🤖 Generated with Claude Code