fix(machine): separated browsers wait for a real extension exchange and never block native reconnects (0.60.1) - #1766
Merged
Conversation
added 3 commits
October 5, 2026 07:12
…nd never block native reconnects Fresh separated profiles could report the native hello before the MV3 extension could service a request, and Browser::exchange held the connection mutex across socket I/O so the accept loop could not install a replacement stream during a reconnect, leaving the first navigation on a wedged pipe until timeout (v0.60.0 Publish Images context secure navigation 12413). Separated browsers now prove one bounded startup exchange before the first action; transport I/O no longer holds the mutex, and a connection generation prevents a late exchange from overwriting a replacement stream. Shared legacy browsers keep their readiness check and timing, and secure-browser operations remain serialized by the runtime's browser lock.
📊 Code coverage
Gate: line coverage must stay at or above the threshold. Ratchet plan (W21): Backend → 55%, CLI → 50%, Frontend → 30% by quarter end. |
chronoai-kai
added a commit
that referenced
this pull request
Oct 5, 2026
…nostics on failure (#1769) Coverage (Backend) and Coverage (Backend Base) lost mongod at the same cumulative point (~840-960 s, auth_device_service tests) on #1765/#1766 with ~7 GB host memory still free; mongod held ~8 GB when it vanished. Raise the descriptor limit far above the nextest peak (thousands of per-test databases' WiredTiger files stay open in one llvm-cov process) and cap the WiredTiger cache at 2 GB. On failure or cancellation, print the container state (exit code, OOMKilled), mongod descriptor count/limits, kernel OOM lines and the server log tail so any recurrence is diagnosable. Co-authored-by: chrono-kw <chrono-kw@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hotfix for the v0.60.0 Publish Images failures (main run 37231036156 and tag run 37231044043). The arm64 machine image smoke and the X64 Machine Container E2E both failed at
context secure navigation:12413 secure browser response timed out.Root cause
Browser::exchangeheld the connection mutex across socket I/O. During a native-host reconnect, the accept loop could not install the replacement stream, so the first request sat on a wedged pipe until its 20 s timeout.The
Authentication failed: Unexpected message typelines in the same logs were transient authority-reconnect retries that later authenticated. They were not the browser failure.Fix
tabsexchange (12 s grace, separate from each operation's 20 s deadline) before the first action, and cache the verification per connection.browserlock, so concurrent exchanges cannot interleave.Validation