Repository navigation
fix: don't recurse into nested index source maps - #25
Merged
Merged
Conversation
Per ECMA-426, the "map" of an index source map section is a regular source map; nested index maps are not allowed. The decoder nevertheless recursed into them via decode() <-> decodeIndexMap() without any depth limit, so a deeply nested (~8000 levels, ~0.5 MiB) map overflowed the call stack with a RangeError. Nested maps were also decoded incorrectly, as the inner call reset the outer section's generated offset to 0:0. decodeIndexMap() now decodes sections with decodeMap() directly and skips sections that are index maps themselves in lax mode, or throws in strict mode.
OrKoN
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per ECMA-426, the "map" of an index source map section is a regular source map; nested index maps are not allowed. The decoder nevertheless recursed into them via decode() <-> decodeIndexMap() without any depth limit, so a deeply nested (~8000 levels, ~0.5 MiB) map overflowed the call stack with a RangeError. Nested maps were also decoded incorrectly, as the inner call reset the outer section's generated offset to 0:0.
decodeIndexMap() now decodes sections with decodeMap() directly and skips sections that are index maps themselves in lax mode, or throws in strict mode.