Repository navigation
fix: bounds-check GENERATED_RANGE_SUBRANGE_BINDING variable indices - #24
Merged
Merged
Conversation
The variable index of a GENERATED_RANGE_SUBRANGE_BINDING item was used as an index into `range.values` without validation. A huge index (e.g. "H//////B" = 2^31 - 1) turned `values` into a sparse array of that length, and the subsequent for-of loop iterated every hole, effectively hanging the decoder on a tiny malicious source map. Sub-range bindings can only refine an existing binding from the GENERATED_RANGE_BINDINGS item, so out-of-bounds (or negative, due to VLQ overflow) indices are now ignored in lax mode and throw in strict mode.
OrKoN
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The variable index of a GENERATED_RANGE_SUBRANGE_BINDING item was used as an index into
range.valueswithout validation. A huge index (e.g. "H//////B" = 2^31 - 1) turnedvaluesinto a sparse array of that length, and the subsequent for-of loop iterated every hole, effectively hanging the decoder on a tiny malicious source map.Sub-range bindings can only refine an existing binding from the GENERATED_RANGE_BINDINGS item, so out-of-bounds (or negative, due to VLQ overflow) indices are now ignored in lax mode and throw in strict mode.