feat: register unit and description - #585
Merged
Merged
Conversation
mhier
approved these changes
Sep 9, 2026
mhier
left a comment
mhier
left a comment
Member
There was a problem hiding this comment.
Maybe we should also test that the description and unit is available in the accessor?
* register unit and description can be set in .jmap * unit and/or description can be overwritten in .xlmap via setDescription plugin * unit and description are available from accessors and catalogue
d-rothe
force-pushed
the
drothe/addDescription
branch
from
September 10, 2026 14:36
19af50a to
b129ff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maybe it makes sense to first merge Christian's changes and then rebase this on top...