Repository navigation
Fix crashes on Android 9/10, organize save, links, text drag; trim ma… - #90
Merged
Merged
Conversation
…rgins, book mode, save a copy - #80: glass buttons crashed on Android 12 and older. The press glow's lazy RuntimeShader property cast to a class that only exists on Android 13+. RuntimeShader now lives in an API 33 object. The press transform and tab bar also skip zero sizes, because the NaN scale they produced crashed Android 9's View layers. - #89: organize, merge and extract saved after closing the source document. importPage shares the source's fonts and images, so any PDF with them failed ("COSStream has been closed"). Sources now stay open until the save, and a failed organize removes its empty output. - #88: dragging a placed text box no longer pans the page. A one-finger pan waits for touch slop and leaves alone a drag that a page child consumed. - #83: PDF links work. Web and mail links open in their app, and jumps inside the document scroll to the target page and position. They are read with the form fields in one PdfBox pass. - #85: Settings > Appearance > Trim page margins. One content rect is measured across the document, and pages are laid out wider and clipped, so overlays keep their coordinates. - #84: Settings > Appearance > Book mode. Each page fits the screen. A fling or a sideways swipe turns exactly one page. - #76: Share has a Save a copy action. It writes the chosen format wherever the user picks, and keeps the file's own name when nothing was edited. - The bar ink sampler reads the real page frame, so book mode's letterbox no longer gets dark icons.
Book mode put the reader's icons over the dark letterbox while the bar's ink still came from the page, so they stayed black on black. One ink per bar also meant a circle over a photo or a page edge followed its neighbours, not its own background. - ProvideScreenInk (Android 8+) copies the window, scaled down, a few times a second, and only after the window has drawn something new. - Each control reads that copy through rememberAdaptiveInk: the corners of its own box (outside the glass) plus the sides level with its glyph, with hysteresis. The bar's old ink is the fallback, which Android 7 and older still use. - This covers the PDF/PPT top bar and reader row, the Word editor header and reading controls, the spreadsheet header and share button, and the shared find bar.
…e names in encrypt/decrypt
Owner
Author
|
Dragging the inserted text when dragged to an another page goes behind of the render instead above the render need to fix this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rgins, book mode, save a copy
What changed?
Why?
Closes #
How was it checked?
./gradlew :app:assembleFossDebugScreenshots or recording
Checklist