Add explicit timeouts to all workflow jobs - #134
Merged
Conversation
den-sq
marked this pull request as ready for review
August 14, 2026 19:37
tavateva
approved these changes
Aug 14, 2026
tavateva
left a comment
There was a problem hiding this comment.
APPROVE — reviewed at head 43a8e57.
AC sweep (#127):
- Every workflow job declares an explicit
timeout-minutes— verified empirically by parsing all seven workflow files at this head with a YAML loader: 8/8 jobs covered (resolve-pr-build10,build-packages45,docs15,coverage15,tag10,publish15,test-coverage15,server-image30). No missed jobs, no eighth workflow file. - buildx / electron-builder bounded well under 6h — the two named hang-prone jobs get 30 and 45 minutes respectively. Job-level timeouts bound teardown as well as the build step, which covers the observed autoseg-class hang; the declared judgment that per-step timeouts are unnecessary duplication is reasonable.
- Healthy margin, no flaky timeouts — cross-checked against this PR's own check runtimes (linux 2m31s, mac 2m3s, win 2m44s, server-image 2m6s, coverage 54s, resolve 4s): margins are 12–45× healthy runtime. Values also match the issue's suggested ranges exactly.
Mechanics: +8/−0, one line per job, each matching its file's existing indentation (no reformatting — the body's prettier note holds). Whitespace check clean. All six CI checks green, MERGEABLE/CLEAN; the edited workflows demonstrably parse since GitHub ran them for this PR.
Undeclared-decision sweep: clean — sizing is declared with a runtime table, and the job-level-vs-step-level choice is declared with grounding.
Verification depth: YAML-parsed every workflow at the PR head and enumerated jobs locally; cross-checked sizing against the live check runtimes; relied on CI for workflow execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeout-minutesvalue to every GitHub Actions jobCloses #127
Timeout sizing
These values leave substantial headroom for dependency and runner variance while ensuring a stuck build or teardown fails well before GitHub's six-hour default.
Validation
timeout-minutesgit diff --checkpassedbuild-docs.yml,pr-coverage.yml, andpython-coverage.yml; the added lines follow those files' current indentation and this PR avoids unrelated full-file reformattingShared-basis audit
.github/workflows/and extended the job definitions directly, which are the canonical ownership point for Actions runtime limits.