Skip to content

fix: critical memory leak in quick_cache#7143

Merged
hanabi1224 merged 4 commits into
mainfrom
hm/fix-quick-cache-mem-leak
Jun 5, 2026
Merged

fix: critical memory leak in quick_cache#7143
hanabi1224 merged 4 commits into
mainfrom
hm/fix-quick-cache-mem-leak

Conversation

@hanabi1224
Copy link
Copy Markdown
Contributor

@hanabi1224 hanabi1224 commented Jun 4, 2026

Summary of changes

Point to my fork until the fix is published
Bump quick_cache to include the fix arthurprs/quick-cache#120

No more leak with the fix
image

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #7130

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a critical memory leak issue that could impact application performance.

@hanabi1224 hanabi1224 added the RPC requires calibnet RPC checks to run on CI label Jun 4, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

Walkthrough

This PR adds a changelog entry documenting a critical memory leak fix in the quick_cache dependency resolved by PR #7143. The entry is placed under the Forest unreleased fixes section.

Changes

Memory Leak Fix Changelog Documentation

Layer / File(s) Summary
CHANGELOG entry for quick_cache memory leak fix
CHANGELOG.md
Added a bullet point under Forest unreleasedFixed documenting PR #7143's resolution of a critical memory leak in quick_cache.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • akaladarshi
  • LesnyRumcajs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: critical memory leak in quick_cache' directly and accurately describes the main change: fixing a memory leak in the quick_cache dependency.
Linked Issues check ✅ Passed The PR addresses the core requirement from #7130 by fixing the memory leak that was causing OOM crashes; the provided memory chart shows memory usage is now bounded after the fix.
Out of Scope Changes check ✅ Passed The PR contains only a changelog entry documenting the fix for the quick_cache memory leak, which is directly within scope of addressing the linked issue #7130.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hm/fix-quick-cache-mem-leak
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/fix-quick-cache-mem-leak

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review June 4, 2026 20:27
@hanabi1224 hanabi1224 requested a review from a team as a code owner June 4, 2026 20:27
@hanabi1224 hanabi1224 requested review from akaladarshi and sudo-shashank and removed request for a team June 4, 2026 20:27
sudo-shashank
sudo-shashank previously approved these changes Jun 4, 2026
@hanabi1224 hanabi1224 enabled auto-merge June 5, 2026 04:11
@hanabi1224 hanabi1224 requested a review from sudo-shashank June 5, 2026 04:11
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.29%. Comparing base (1081229) to head (2035f88).
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1081229...2035f88. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hanabi1224 hanabi1224 added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 32abff9 Jun 5, 2026
42 checks passed
@hanabi1224 hanabi1224 deleted the hm/fix-quick-cache-mem-leak branch June 5, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Memory leak regression

2 participants