Skip to content

Validate short link login passwords with the password validator #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cozmiccle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Validate short link login passwords with the password validator #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/routes/api/v2/short_link/+server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import type { RequestHandler } from './$types';
import { ShortLink } from './model';
import {
shortLinkCreateValidator,
shortLinkPasswordValidator,
shortLinkSuffixValidator,
shortLinkUrlUpdateValidator,
} from './validator';
Expand Down Expand Up @@ -43,7 +44,9 @@ export const POST: RequestHandler = async ({ request }) => {
export const GET: RequestHandler = async ({ url }) => {
try {
const suffix = await shortLinkSuffixValidator.validate(url.searchParams.get('suffix'));
const password = await shortLinkSuffixValidator.validate(url.searchParams.get('password'));
const password = await shortLinkPasswordValidator
.required()
.validate(url.searchParams.get('password'));

const found = await ShortLink.findOne({ suffix: suffix }).select('+hash');
if (!found) return error(404, { message: 'Short link not found' });
Expand Down Expand Up @@ -74,7 +77,9 @@ export const GET: RequestHandler = async ({ url }) => {
export const PATCH: RequestHandler = async ({ request, url }) => {
try {
const suffix = await shortLinkSuffixValidator.validate(url.searchParams.get('suffix'));
const password = await shortLinkSuffixValidator.validate(url.searchParams.get('password'));
const password = await shortLinkPasswordValidator
.required()
.validate(url.searchParams.get('password'));

const req = await request.json();
const validatedReq = await shortLinkUrlUpdateValidator.validate(req, { stripUnknown: true });
Expand Down Expand Up @@ -108,7 +113,9 @@ export const PATCH: RequestHandler = async ({ request, url }) => {
export const DELETE: RequestHandler = async ({ url }) => {
try {
const suffix = await shortLinkSuffixValidator.validate(url.searchParams.get('suffix'));
const password = await shortLinkSuffixValidator.validate(url.searchParams.get('password'));
const password = await shortLinkPasswordValidator
.required()
.validate(url.searchParams.get('password'));

const found = await ShortLink.findOne({ suffix: suffix }).select('+hash');
if (!found) return error(404, { message: 'Short link not found' });
Expand Down
Loading