Skip to content

Expose Shawarma command names through KnownShawarmaCommands #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
centeredgebot merged 2 commits into from
Jun 25, 2026
Merged

Expose Shawarma command names through KnownShawarmaCommands #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57b29b5
Expose Shawarma command names through `KnownShawarmaCommands`
JonathanAtCenterEdge Jun 25, 2026
4e62cc5
hyphens
JonathanAtCenterEdge Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/Shawarma.Aspire.Hosting/KnownShawarmaCommands.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
namespace Shawarma.Aspire.Hosting;

/// <summary>
/// Known Aspire command names for Shawarma Aspire services.
/// </summary>
public static class KnownShawarmaCommands
{
/// <summary>
/// The command name for enabling Shawarma services.
/// </summary>
public const string EnableShawarma = "enable-shawarma";

/// <summary>
/// The command name for disabling Shawarma services.
/// </summary>
public const string DisableShawarma = "disable-shawarma";
}
9 changes: 3 additions & 6 deletions src/Shawarma.Aspire.Hosting/ShawarmaResourceBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@ namespace Shawarma.Aspire.Hosting;
/// </summary>
public static class ShawarmaResourceBuilderExtensions
{
private const string EnableShawarmaCommandName = "enableShawarma";
private const string DisableShawarmaCommandName = "disableShawarma";

private static readonly string[] s_httpSchemes = ["https", "http"];

private static Func<EndpointReference> NamedEndpointSelector<TResource>(IResourceBuilder<TResource> builder, string endpointName)
Expand Down Expand Up @@ -141,7 +138,7 @@ await notificationService.PublishUpdateAsync(builder.Resource,
path: options.ApplicationStatePath,
displayName: "Start Shawarma Services",
endpointSelector: endpointSelector,
commandName: EnableShawarmaCommandName,
commandName: KnownShawarmaCommands.EnableShawarma,
commandOptions: new HttpCommandOptions
{
Method = HttpMethod.Post,
Expand Down Expand Up @@ -179,7 +176,7 @@ await notificationService.PublishUpdateAsync(builder.Resource,
path: options.ApplicationStatePath,
displayName: "Stop Shawarma Services",
endpointSelector: endpointSelector,
commandName: DisableShawarmaCommandName,
commandName: KnownShawarmaCommands.DisableShawarma,
commandOptions: new HttpCommandOptions
{
Method = HttpMethod.Post,
Expand Down Expand Up @@ -224,7 +221,7 @@ await notificationService.PublishUpdateAsync(resource,
{
var commandService = e.Services.GetRequiredService<ResourceCommandService>();

var result = await commandService.ExecuteCommandAsync(resource, EnableShawarmaCommandName, cancellationToken);
var result = await commandService.ExecuteCommandAsync(resource, KnownShawarmaCommands.EnableShawarma, cancellationToken);
if (result is { Success: false, Canceled: false })
{
throw new InvalidOperationException($"Failed to enable Shawarma services on startup: {result.ErrorMessage}");
Expand Down
Loading