Add unit tests for embedding_service and retrieval_service #39
Merged
Conversation
AJaccP
approved these changes
Jul 26, 2026
AJaccP
left a comment
AJaccP
left a comment
Contributor
There was a problem hiding this comment.
Tests look good! Looks like the initial CI failure was because this branch and main each added pytest-cov to uv.lock independently, in different parts of the file. Git merged both in without a conflict, so the merged lock ended up with two coverage entries and uv couldn't parse it.
Fixed by merging main and taking main's uv.lock, since pyproject.toml is now identical to main's either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #15
Adds unit tests for embedding_service and retrieval_service using mocks (no Ollama/Docker required for these tests). make test and make lint both pass.