Add navbar icons #5#31
Conversation
| "@dagrejs/dagre": "^3.0.0", | ||
| "@xyflow/react": "^12.10.2", | ||
| "lucide-react": "^1.22.0", | ||
| "nvm": "^0.0.4", |
There was a problem hiding this comment.
Looks like a stray package got added unrelated to the ticket change, I'm guessing from a pnpm add nvm or something. The change doesn't need this so please run pnpm remove nvm on this branch and commit the updated package.json and pnpm-lock.yaml
Assuming it works as expected there should be no diff for these 2 files against main, so only the Header.tsx file would have changes in the PR.
| <nav className="flex items-center gap-6"> | ||
| <NavLink to="/explorer" className={linkClass}> | ||
| Explorer | ||
| <Network size={20} /> Explorer |
There was a problem hiding this comment.
For the size of the icons, I think 16 looks better than 20 + it's consistent with the other lucide usage in the site's legend component. Can you please update size to 16 on both
| @@ -1,22 +1,26 @@ | |||
| import { NavLink } from 'react-router-dom'; | |||
| import { Network } from 'lucide-react'; | |||
There was a problem hiding this comment.
Nitpick but since both are from the same module, this can be one import line:
import { Network, CalendarDays } from 'lucide-react';
Also the comment on line 5 can be removed since its just duplicating what the import already says
2 participants
No description provided.