Repository navigation
Conversation
… and surface send failures Self-hosts without RESEND_FROM_DOMAIN sent from auth@undefined, which Resend rejects, while the UI still said a code was sent. Email is now treated as configured only when the API key and sender are both available, login codes are logged otherwise, the verify screen says email is not configured, explicit fromOverride senders keep working without a default domain, and invite APIs report not_configured instead of accepted.
Contributor
|
@07rjain is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
6 tasks
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+176
to
+184
| {emailDeliveryConfigured ? ( | ||
| <p className="text-sm text-gray-10"> | ||
| We sent a 6-digit code to {normalizedEmail} | ||
| </p> | ||
| ) : ( | ||
| <p className="text-sm text-gray-10"> | ||
| Email (Resend) is not configured on this server. The 6-digit code | ||
| for {normalizedEmail} was printed to the server logs. Ask your | ||
| administrator, or set RESEND_API_KEY and RESEND_FROM_DOMAIN. |
Contributor
There was a problem hiding this comment.
The new emailDeliveryConfigured flag fixes the page text, but the resend toast still says “A new code has been sent to your email!” when email is disabled. Requesting another code only prints it to the server logs. Use the flag in handleResend.onSuccess too, so users are not sent back to their inbox.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/web/app/(org)/verify-otp/form.tsx
Line: 176-184
Comment:
**Resend still promises an email**
The new `emailDeliveryConfigured` flag fixes the page text, but the resend toast still says “A new code has been sent to your email!” when email is disabled. Requesting another code only prints it to the server logs. Use the flag in `handleResend.onSuccess` too, so users are not sent back to their inbox.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Comment on lines
+190
to
+191
| const error = result.value?.error; | ||
| return Boolean(error && error.name !== "email_not_configured"); |
Contributor
There was a problem hiding this comment.
Excluding email_not_configured from failedInvites keeps the invite links usable, but it also leaves failedEmails empty. InviteDialog then shows “Invites sent successfully” without warning that no email was sent. Return a separate delivery status and show the skipped-email notice without deleting the invite records.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/web/actions/organization/send-invites.ts
Line: 190-191
Comment:
**Skipped invites look sent**
Excluding `email_not_configured` from `failedInvites` keeps the invite links usable, but it also leaves `failedEmails` empty. `InviteDialog` then shows “Invites sent successfully” without warning that no email was sent. Return a separate delivery status and show the skipped-email notice without deleting the invite records.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #2580 (email delivery status).
RESEND_API_KEYbut noRESEND_FROM_DOMAINsent fromauth@undefined. Resend rejects that, but the UI still said a code was sent.getEmailDeliveryStatus()/sendEmail()now returnemail_not_configuredwhen no usable sender exists. An explicitfromOverridestill works without a default domain.emailDelivery: "not_configured"instead ofaccepted.AgentOrganizationInviteResponsegains that literal.Tests.
email-config.test.ts.The PR appears safe to merge, with two non-blocking messages that still claim skipped emails were sent.
Findings
Fix with agent prompt
Summary
The PR stops self-hosted email from using
auth@undefinedand reports missing email settings.07rjainexplicitly intends login codes to appear in server logs when email is not configured.Reviews (1) · Last reviewed commit: "fix(email): never send from auth@undefin..." · Reviewed by Greptile