[ghazy2001]

Fixes #2976

Summary

When viewing a video on the share page (/s/<videoId>) as an unauthenticated or logged-out viewer, clicking any of the emoji reaction buttons (😂, 😍, 😮, 🙌, 👍, 👎) in the toolbar previously did nothing. The interaction was silently swallowed because handleEmojiClick checked if (!canReact || !user) return;.

In contrast, other viewer interactions on the toolbar (e.g. clicking Comment (c)) and sidebar (clicking the comment placeholder) consistently prompt the AuthOverlay modal ("Sign in to comment - Join the conversation.") so viewers can sign in and participate.

Root Cause

In apps/web/app/s/[videoId]/_components/Toolbar.tsx, handleEmojiClick checked:

if (!canReact || !user) return;

If user was falsy, execution returned early without triggering setShowAuthOverlay(true).

Solution

1. Extracted Reaction Handler & Definitions (toolbar-reactions.ts):
   • Extracted standard REACTIONS definitions and handleEmojiReaction guard logic into a focused helper.
   • Guard checks:
     • Returns early if !canReact.
     • Calls onRequireAuth() (setShowAuthOverlay(true)) when viewer is unauthenticated (!user).
     • Dispatches optimistic comment and backend submission when viewer is authenticated.
2. Updated Toolbar.tsx:
   • Uses handleEmojiReaction to trigger setShowAuthOverlay(true) upon unauthenticated emoji clicks, matching the behavior of the Comment (c) button.
3. Unit Tests (toolbar-reactions.test.ts):
   • Added 5 unit tests covering:
     • Exposing standard reaction set in display order.
     • Prompting sign-in overlay when user is null.
     • Prompting sign-in overlay when user is undefined.
     • Suppressing interaction when reactions are disabled (canReact = false).
     • Submitting reaction when viewer is signed in.
   • Tested and formatted with Biome (0 errors, 0 warnings).

Confidence Score: 5/5

The PR appears safe to merge; no actionable issues were found.

Summary

Logged-out viewers now get the existing sign-in overlay when they click an emoji reaction.

• Emoji clicks on shared video pages open the sign-in overlay for signed-out viewers.

Reviewed the full PR because the current and previously reviewed commits have different merge bases. No previous review threads were supplied. Checks were based on code; tests and browser behavior were not run.

_{Reviews (2) · Last reviewed commit: "Merge branch 'main' into fix/toolbar-rea..." · Reviewed by Greptile}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
cap-status	Skipped		Oct 23, 2026 9:45pm UTC

[richiemcilroy]

Thanks @ghazy2001, good catch on #2976, opening the sign-in overlay for logged-out reactions matches how the comment button behaves. One small change before we merge: in Toolbar.tsx the onReact callback no longer knows user is set, so it now builds the optimistic comment with authorId: user?.id ?? "" and ?? null fallbacks that can never actually run (and would create an author-less comment if they did). Could you pass the narrowed user through, for example onReact: (emoji, user) => ... from handleEmojiReaction in toolbar-reactions.ts, and drop the fallbacks? Alternatively the whole fix can just be if (!canReact) return; if (!user) { setShowAuthOverlay(true); return; } at the top of the existing handleEmojiClick. Either is fine with us.

[ghazy2001]

Hi @richiemcilroy,

Thanks for the feedback! I've updated handleEmojiReaction to pass the narrowed, non-null user directly to onReact(emoji, user). In Toolbar.tsx, authedUser is now used directly to construct the optimistic comment and API payload without any ?? "" or ?? null fallbacks (authedUser.id, authedUser.name, authedUser.imageUrl). The unit tests have also been updated to verify the forwarded user parameter (5/5 passing).

Ready for merge!

[richiemcilroy]

@greptileai review