Repository navigation
feat(rendering): add opt-in macOS software codec mode #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AasishDairelSahayaGrinspan
wants to merge
3
commits into
CapSoftware:main
Choose a base branch
from
AasishDairelSahayaGrinspan:split/macos-software-codecs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+95
−12
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
0708fdf
fix(rendering): add opt-in macOS software codec mode
AasishDairelSahayaGrinspan 532ae20
fix(rendering): honor software codecs in managed decoders
AasishDairelSahayaGrinspan cc24d9a
fix(enc-ffmpeg): limit software codec env to export encoding
AasishDairelSahayaGrinspan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting
CAP_MACOS_SOFTWARE_CODECS=1does not force software decoding in the preparing editor preview. This check only coversspawn_decoder, while that preview usesspawn_managed_decoder. The desktop enables hardware decoding on macOS, and the managed decoder forwards that choice unchanged, so FFmpeg still selects VideoToolbox. Users can therefore still get the integrated-GPU activity this option is meant to avoid. Apply the software-codec setting to the managed decoder path too.Prompt To Fix With AI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 0550695.
spawn_managed_decodernow appliesCAP_MACOS_SOFTWARE_CODECSbefore constructing the FFmpeg decoder, so the preparing preview and camera managed decoders use software decoding too.