Repository navigation
fix(enc-ffmpeg): preserve AAC quality for high sample rate inputs - #2895
Merged
richiemcilroy merged 4 commits intoOct 23, 2026
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the aac encoder picks the lowest supported rate at or above the input rate, and if none was high enough it fell back to the first entry of the sorted list, which is 7.35 khz. so audio from a 192 khz interface got squashed down to 7.35 khz and lost everything above about 3.5 khz.
now the fallback is the highest supported rate, 96 khz. inputs the codec already supports are unchanged. tests check the chosen rate for low, normal and too high inputs, and push a 12 khz tone at 192 khz through encode and decode to make sure it survives.


Confidence Score: 5/5
This PR appears safe to merge.Summary
High-rate AAC inputs now fall back to the highest supported sample rate instead of the lowest.
Reviewed statically; tests were not run.
Reviews (1) · Last reviewed commit: "fix(enc-ffmpeg): preserve AAC quality fo..." · Reviewed by Greptile