Skip to content

chore(wren-core-py): sync wren-core-py uv.lock on release#2383

Merged
PaulChen79 merged 1 commit into
mainfrom
fix/release-please-wren-core-py-uvlock
Jun 22, 2026
Merged

chore(wren-core-py): sync wren-core-py uv.lock on release#2383
PaulChen79 merged 1 commit into
mainfrom
fix/release-please-wren-core-py-uvlock

Conversation

@goldmedal

@goldmedal goldmedal commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Why

The wren-core-py release PR (#2376) fails CI on every job at the install step:

The lockfile at `uv.lock` needs to be updated, but `--locked` was provided.
Process completed with exit code 1.

release-please bumps core/wren-core-py/pyproject.toml (0.7.00.7.1) but never updates core/wren-core-py/uv.lock, which keeps wren-core-py pinned at the old version. Since uv.lock records the project's own version (source = { editable = "." }), it goes stale the moment the version bumps, and uv sync --locked refuses to run — blocking Core Python CI and all Wren SDK CI jobs (which build the wren-core-py wheel first).

Fix

Add a uv.lock extra-files entry for core/wren-core-py, mirroring the existing core/wren config so the lockfile version is updated via jsonpath alongside the pyproject.toml/Cargo.toml bump.

Once merged, release-please will regenerate the open release PR (#2376) with the lockfile change included, turning CI green.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated release configuration to improve package version tracking.

The wren-core-py release PR bumps pyproject.toml but leaves uv.lock
pinned to the old version, so every CI job fails at `uv sync --locked`.
Mirror the core/wren config to update uv.lock via jsonpath alongside the
version bump.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

In release-please-config.json, the extra-files list for core/wren-core-py is extended by adding a uv.lock entry typed as toml with a jsonpath that targets the wren-core-py package version, alongside the existing Cargo.toml entry.

Changes

Release-Please Config: wren-core-py uv.lock version tracking

Layer / File(s) Summary
Add uv.lock extra-files entry
release-please-config.json
Adds a uv.lock object (type: toml) with a jsonpath pointing to the wren-core-py package version to the extra-files list for core/wren-core-py, keeping the existing Cargo.toml entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Canner/WrenAI#2351: Also updates release-please-config.json to add a uv.lock extra-files entry with a jsonpath selector for a package version, the same pattern applied here for wren-core-py.

Suggested labels

dependencies, python, core

Poem

🐇 A lock file now joins the release parade,
With jsonpath carved and a toml bridge laid.
The version hops neatly from uv.lock each time,
No version left lost, every release in rhyme!
— Signed, a very organized bunny 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and specifically describes the main change: configuring release-please to sync the uv.lock file during wren-core-py releases.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-please-wren-core-py-uvlock

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@goldmedal goldmedal changed the title chore: sync wren-core-py uv.lock on release chore(wren-core-py): sync wren-core-py uv.lock on release Jun 22, 2026
@goldmedal goldmedal requested a review from PaulChen79 June 22, 2026 02:10
@PaulChen79 PaulChen79 merged commit abeb845 into main Jun 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants