-
Notifications
You must be signed in to change notification settings - Fork 15
Image smoothing as a setting #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Changes from all commits
8c573b3
1162e09
68152bc
f055458
d9136fe
9fc33bb
f9618b1
1650678
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -106,6 +106,7 @@ Wick.Project = class extends Wick.Base { | |||||
| this.activeTool = 'cursor'; | ||||||
|
|
||||||
| this._toolSettings = new Wick.ToolSettings(); | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| this._toolSettings.project = this | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it correct to do this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Isn't it simpler to just ask the project in the tool settings' constructor? |
||||||
| this._toolSettings.onSettingsChanged((name, value) => { | ||||||
| if (name === 'fillColor') { | ||||||
| this.selection.fillColor = value.rgba; | ||||||
|
|
||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,6 +49,10 @@ Wick.View.Path = class extends Wick.View { | |
|
|
||
| this.importJSON(this.model.json); | ||
|
|
||
| if(this.model.pathType == 'image') { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This |
||
| this.item.smoothing = this.model.project.toolSettings.getSetting('imageSmoothing') | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Cache this also. |
||
| }; | ||
|
|
||
| // Apply onion skin style if Needed | ||
| // (This is done here in the Path code because we actually change the style of the path | ||
| // if the current onion skin mode is set to "outlines" or "tint") | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this get added, and is it safe to other unchanged code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.