Repository navigation
ci: route changes through staging - #216
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Adds
stagingas the testing branch in front ofmain, the same flow SleakCraft uses. Pull requests go intostaging,mainonly takes pull requests fromstaging, and both need CI plus a maintainer's approval.Why
Every game builds against engine
main, so an engine change was live for all of them the moment it merged. SleakCraft already tests instaging, but its CI could only build against enginemain, so a change that spans both repos could not be tested before release.What is in it
branch-policy.yml: the Only staging merges into main check, copied from SleakCraft.ci.yml: runs onstagingtoo. The downstream game build checks out the SleakCraft branch matching the pull request's base, so enginestagingis tested with gamestaging.dependabot.yml: updates targetstaging..github/rulesets/:main.jsonandstaging.json(pull requests only, CI, no force push or deletion, merge commits only onmain) andapproval.json(one approval; admins may bypass it through a pull request, since authors cannot approve their own).CONTRIBUTING.mdand the pull request template describe the flow.How it was verified
YAML and JSON parse. The workflow changes run for the first time on this pull request.