Repository navigation
Define DEBUG for MSVC Debug builds - #92
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Defines
DEBUGfor Debug builds on MSVC with a$<CONFIG:Debug>generator expression. Visual Studio is a multi-config generator and ignoresCMAKE_BUILD_TYPE, so the old check never defined it on Windows. The Linux path is unchanged.Merge CanReader/SleakEngine#225 first. Windows Debug builds need its
Vector.hppfix to compile. CI here builds against the engine'sfix/windows-debug-buildbranch until then.Why
Everything behind
#ifdef DEBUGwas compiled out on Windows, including-world, which quietly fell back to the main menu. The engine'sLogger.cppandVulkanBuffer.cppuse it too.How it was verified
-world HotReloadTest, DX11) and editedflat_shader.hlslwhile it ran; it reloadedOnly a build flag changed, so placing, breaking and saving weren't exercised. Tested locally on top of
mainplus #90, not on top of the currentstaging.Checklist
.spv(no shader changes)WorldMeta::CURRENT_VERSIONand handle old worlds (no save changes)