Repository navigation
Move to the 2024 edition - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
edition = "2024"inCargo.toml. Theextern "C"block insrc/cuda/ffi.rsbecomesunsafe extern "C", which the new edition requires. The second commit iscargo fmtunder the 2024 style, 39 files for a net change of about ten lines, kept separate so the first commit stays readable.Why
2021 was the default when the project started. The 2024 edition has been stable since Rust 1.85 and the MSRV is 1.87, so nothing holds it back, and new code should not be written against an old edition.
How it was verified
cargo testpassescargo clippy --all-targets -- -D warningsis cleancuda_parityon a GPU--releasecargo fix --editionran under 2021 first, then the flip.cargo build --all-targetson 2024 is warning free. The migration lint flagged two tail-expression drop-order changes intests/gradcheck.rs; both involve temporaries around a CPU tensor, where the order does not matter.cuda_paritypassed on an RTX 4050, 16 cases.cargo docwith-D warningsis clean.Checklist
tensor/opsandautograd/opsstill mirror each other///docs