Conversation
robyww
force-pushed
the
FIREFLY-1978-viz-upload
branch
from
9b48ffd to
dcfa04a
Compare
Contributor
|
yes, this works! :) |
loitly
requested changes
Apr 10, 2026
Contributor
loitly
left a comment
loitly
left a comment
There was a problem hiding this comment.
Still not working for me.
Steps to duplicate:
- TAP -> VizieR
- Upload table
- Select all columns
- Unselect Temporal
- Populate and Edit ADQL
- Note the double double-quotes?
- Click Search
The search failed with:
Job has failed with the error: Incorrect ADQL query: Encountered ".5". Was expecting one of: "," "FROM"
| export const getAsEntryForTableName= (tableName) => tableName?.[0] ?? 'x'; | ||
| export function getTableNameAlias(tableName) { | ||
| if (!tableName) return 'x'; | ||
| if (tableName.length > 1 && tableName[0]==='"') return tableName[1].toLowerCase(); |
Contributor
There was a problem hiding this comment.
Is there a reason why it needs to be in lower case?
Contributor
Author
There was a problem hiding this comment.
The VizieR sever would not accept uppercase without an error.
Comment on lines
+619
to
+622
| if (!isTable && name.includes('.')) { | ||
| const [table,col, ...rest]= name.split('.'); | ||
| if (table.length && col.length && !rest.length) return `${table}.${maybeQuote(col)}`; | ||
| } |
Contributor
There was a problem hiding this comment.
You are throwing away the leftovers(..rest). Is this to fix bad names?
Contributor
Author
There was a problem hiding this comment.
yea, that is the bug.
robyww
force-pushed
the
FIREFLY-1978-viz-upload
branch
3 times, most recently
from
64988ea to
8d3c1a3
Compare
loitly
approved these changes
Apr 16, 2026
|
|
||
| export const findDataLinkServeDescs= (sdAry=[]) => | ||
| sdAry?.filter( (serDef) => isDataLinkServiceDesc(serDef) ?? []); | ||
| sdAry?.filter( (serDef) => Boolean(isDataLinkServiceDesc(serDef))); |
Contributor
There was a problem hiding this comment.
Why is Boolean needed? I think if anything, it may produces false positive.
Contributor
Author
There was a problem hiding this comment.
just for readability. the bug was the empty array.
- IRSA-7666: fixed: non-datalink service descriptor intepreted wrong - response to feedback: fixed several bugs - some clean up of hips - disable webgpu on firefox
robyww
force-pushed
the
FIREFLY-1978-viz-upload
branch
from
8d3c1a3 to
d23d816
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-1978: fixed VizieR upload
Testing