feat: add form-based params builder to ApiUsage#347
Open
IfyJustin91 wants to merge 1 commit into
Open
Conversation
Closes CalloraOrg#150 - Add ParamsBuilder component with form and raw-JSON modes - Each row: key input, type selector (string/number/boolean), value input, remove button - Form→raw serialises rows; raw→form parses and surfaces inline errors - Empty state shows 'No parameters yet' with Add CTA - Live count badge next to heading in form mode - Tab order: key → type → value → remove per row - Boolean type-switch auto-defaults value to 'true' - Raw mode: live JSON validation with aria-live status - Replace RequestBodyEditor in ApiUsage.tsx with ParamsBuilder - Add .params-builder__row grid styles to index.css - 33 passing tests covering all acceptance criteria
|
@IfyJustin91 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a dual-mode parameters editor for API test calls, replacing the freeform JSON textarea with a proper form-based builder.
Changes
trueTests
All 33 ParamsBuilder tests pass. Pre-existing failures in FiltersSidebar, FiltersBottomSheet, and schema-validate are unrelated to this PR (present on main before this branch).
Acceptance Criteria
Closes #150