Resolves issue #1771, Fixes the review object history to correctly reflect modified data when an approver modifies the request during approval.#1812
Merged
Conversation
cberger8
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes Issue #1771
Summary
This PR fixes a bug where an approver modifying a review object during approval would successfully update the organization with the new data, but the review object history would erroneously retain the original requested data. The fix ensures that any modifications made during approval are properly persisted to the
new_review_datafield of the review object.Important Changes
src/controller/review-object.controller/review-object.controller.jsbodypayload down to theapproveReviewOrgObjectrepository function to capture the modified data.src/repositories/reviewObjectRepository.jsapproveReviewOrgObjectto accept an optionalmodifiedBodyparameter.modifiedBodytoreviewObject.new_review_dataprior to saving the approved status.test/integration-tests/review-object/reviewObjectTest.jsnew_review_data.Testing
Steps to manually test updated functionality:
npm run test:integration) to ensure no regressions.new_review_datadisplays the modified data, not the original pending data.Notes