Skip to content

Fix logs disappearing when a container is stopped | ROVER-629 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaydizz0 wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −4
Open

Fix logs disappearing when a container is stopped | ROVER-629 #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12fee68
Keep container logs visible until a new container starts, not on ever…
jaydizz0 Jul 24, 2026
180d494
Fix comments
codeflight1 Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/components/ContainerCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,19 @@ const ContainerCard: React.FC<ContainerCardProps> = ({
const socketRef = useRef<WebSocket | null>(null);
const logBoxRef = useRef<HTMLPreElement>(null);

// Sync status and clear logs/eventMsg when container ID changes (new container after restart)
// Keep local status in sync whenever the parent reports a new one
useEffect(() => {
setStatusState(option.status);
setLogs([]);
}, [option.status]);

useEffect(() => {
setEventMsg(externalEventMsg);
}, [option.id, externalEventMsg, option.status]);
}, [externalEventMsg]);

// Only clear logs when a new container starts (id changes)
useEffect(() => {
setLogs([]);
}, [option.id]);

const handleStart = async () => {
await onStart(key);
Expand Down Expand Up @@ -128,7 +135,7 @@ const ContainerCard: React.FC<ContainerCardProps> = ({
</p>
)}

{statusState !== 'stopped' && (
{(statusState !== 'stopped' || logs.length > 0) && (
<div style={{ marginTop: 12 }}>
<strong>Live Logs:</strong>
<pre
Expand Down
Loading