feat: add headlights to usb servo controller - #181
Open
ConnorNeed wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elec does not want another board in the elec box. I do not blame them. Although it will flicker a little bit we want to try driving the LEDs via PWM from the servo controller. 20000 micro seconds = 20ms = 50hz = 100 duty cycle. A bit of a hack but I have seen worse.
Any chance @codeflight1 can test it for me since I didn't want to disrupt Jack's practice last night. I'll be in at 6 otherwise. Pretty low risk change so I would like to get it merged in and built before tonight.