Repository navigation
Feature/422 wire new authentication to soarca api - #425
Open
MaartendeKruijf wants to merge 7 commits into
Open
MaartendeKruijf wants to merge 7 commits into
MaartendeKruijf wants to merge 7 commits into
Conversation
MaartendeKruijf
force-pushed
the
feature/422-wire-new-authentication-to-soarca-api
branch
from
October 14, 2026 15:48
5291511 to
3f9174f
Compare
Paul2803k
reviewed
Oct 15, 2026
| ClientId string `env:"OIDC_CLIENT_ID"` | ||
| SkipTlsVerify bool `env:"OIDC_SKIP_TLS_VERIFY" envDefault:"false"` | ||
| // Members of AUTH_GROUP get every permission, as they did with gauth. | ||
| // Members of AUTH_GROUP get every permission. |
Collaborator
There was a problem hiding this comment.
nitpick: instead of AUTH_GROUP wouldnt be something like ADMIN_AUTH_GROUP or ADMIN_GROUP be more obvious?
Collaborator
Author
There was a problem hiding this comment.
Yeah I think that is a good adaption I will fix that
Paul2803k
reviewed
Oct 15, 2026
| // the UI's Authorize button adds. | ||
| route(http.MethodGet, "/swagger/*any"): {Public: true}, | ||
|
|
||
| route(http.MethodGet, "/status/"): {Permission: roles.PlaybookRead}, |
Collaborator
There was a problem hiding this comment.
question: should this behind PlaybookRead permissions? Not public?
Collaborator
Author
There was a problem hiding this comment.
Good catch I think this even should get it's own permission with StatusRead or Reader
Paul2803k
previously approved these changes
Oct 15, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.