Repository navigation
bug: bump auth0-js to ^9.12.0 to clear crypto-js@3.3.0 weak PRNG (SNYK-JS-CRYPTOJS-18599395) - #601
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…K-JS-CRYPTOJS-18599395)
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code-scan finding
sfind-db438260(SNYK-JS-CRYPTOJS-18599395 / CVE-2026-71851, medium): crypto-js@3.3.0 has a weak PRNG inWordArray.random.Vulnerable path:
admin-portal > auth0-js@8.12.3 > idtoken-verifier@1.5.1 > crypto-js@3.3.0.idtoken-verifier@1.5.1requirescrypto-js: ^3.1.9-1, so no 3.x version fixes it. This PR follows Snyk's upgrade path:auth0-js@9.12.0 > idtoken-verifier@2.2.4 > crypto-js@4.2.0.auth0-jsis not imported anywhere underAdminPortal/src(it is only declared inpackage.json), so the app bundle and runtime behaviour are unchanged.overrides(as in open PR bug: override transitive crypto-js 3.3.0 with 4.2.0 in AdminPortal (SNYK-JS-CRYPTOJS-18599395) #264): the repo's toolchain is Node 12 / npm 6.14.16 (see the environment blueprint). npm 6 ignoresoverrides, which needs npm >= 8.3. On this VMnpm ls crypto-jsstill resolvescrypto-js@3.3.0under that toolchain. A direct-dependency bump works with any npm version.overridesapproach) and the auth0-js 9.x/10.x bumps in bug: bump auth0-js to ^9.13.2 in AdminPortal (CVE-2020-5263) #237/bug: bump auth0-js to ^9.0.0 in AdminPortal (CVE-2018-6874) #287/bug: upgrade auth0-js to ^10.0.0 in AdminPortal (CVE-2026-42280) #269. Only one of them should land.Verification
ng build(JIT, Node 12): passes on this branch.ng test: was already broken onmasterand is unaffected by this change.tsc -p src/tsconfig.spec.jsonreports TS2346 in 4 generated component specs (appointment,login,primary-transaction,savings-transaction), and karma aborts.npm installand the Snyk re-scan. This session's network policy blocksregistry.npmjs.organdapi.snyk.io. Access was requested but had not been approved when this PR was opened, so the before/after Snyk issue count could not be measured.npm ls crypto-jsshowsauth0-js@8.12.3 > idtoken-verifier@1.5.1 > crypto-js@3.3.0, which is 1 instance of SNYK-JS-CRYPTOJS-18599395.cd AdminPortal && npm install && snyk test.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/2ec40a516ac446d89459cefbe067af71
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/2ec40a516ac446d89459cefbe067af71?variant=devin
Devin Review