Repository navigation
bug(security): upgrade embedded Tomcat to 9.0.109 (CVE-2025-55752) - #597
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code-scan finding
sfind-5ab9fefa(SNYK-JAVA-ORGAPACHETOMCATEMBED-13733966 / CVE-2025-55752, CWE-23, high). UserFront pulls intomcat-embed-core@8.5.15throughspring-boot-starter-web@1.5.4.RELEASE.This is a major bump (Tomcat 8.5 to 9.0), flagged on purpose. 8.5.x is EOL and has no fixed release. 9.0.109 is the smallest fixed version, and it still runs on Java 8. Spring Boot stays on 1.5.4 and Java stays on 1.8. Snyk's suggested path (Boot 3.4.10 / Tomcat 10.1.46) would need Java 17, which the remediation guidance forbids.
config/TomcatConfigis required. Boot 1.5'sTomcatEmbeddedServletContainerFactoryregisters Tomcat's default servlet withContext.addServletMapping(String,String), and Tomcat 9 removed that method. Without this class, startup fails withNoSuchMethodError.TomcatConfigcallssetRegisterDefaultServlet(false). Static assets underclasspath:/staticare still served by Spring MVC's resource handler. The class is the same one used in PR #177.Caveat: Spring Boot 1.5 was never supported on Tomcat 9.
server.compression.enabled=truewould also break, but UserFront doesn't set it. The supported long-term fix is a Boot 2.x upgrade.Overlap with other PRs (only one should land): #177 pins 9.0.106, which is below the fix for this CVE. #229 (9.0.117), #208 (9.0.118) and #230 (Boot 2.7.18 + 9.0.118) also clear this CVE. #87/#131/#132/#141 pin 8.5.x and will conflict on
tomcat.version.Verification
mvn -o compilefails withUnresolvableModelException.UserFrontApplicationTestsalso needs MySQL.snyk test --file=pom.xmlfails with SNYK-CLI-0000 because the API isn't reachable. From the dependency tree, the onlytomcat-embed-coremoves from 8.5.15 (affected) to 9.0.109 (the first fixed 9.0.x release). Please re-run Snyk to confirm the issue clears.--release 8, run on JDK 11). It imports this PR'sTomcatConfigand serves UserFront'ssrc/main/resources. 9.0.83 is the newest cached 9.0.x jar, so the exact 9.0.109 jar was not exercised./ping200,/css/bootstrap.css200text/css,/WEB-INF/x404NoSuchMethodError: Context.addServletMapping/ping200,/css/bootstrap.css200text/css, unknown path 404,/WEB-INF/x404Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/e0bdd846d7614600bee291447603fd50
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/e0bdd846d7614600bee291447603fd50?variant=devin
Devin Review