Repository navigation
feature: Spring Boot 3.5.12 (spring-webmvc 6.2.17) to clear CVE-2026-22735 - #581
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
Devin Review found 1 potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Snyk
SNYK-JAVA-ORGSPRINGFRAMEWORK-15701756/ CVE-2026-22735 (spring-webmvc SSE plain-text injection, low) reported onUserFront/pom.xml:30(code-scan findingsfind-fd3c4494).spring-webmvc4.3.9 comes in throughspring-boot-starter-parent1.5.4. The fix only exists in 6.2.17+ / 7.0.6+, so this uses Snyk's own upgrade path, the smallest Boot release that pulls in 6.2.17:Warning
Flagged: this is a major bump and it changes the Java version. The remediation guidance says "do not change the Java version", but no Java 8 Spring line has this fix (4.3.x/5.3.x OSS are not patched, and Spring 6 needs Java 17). The only alternative is to leave the finding open. Reviewers should decide whether a Boot 3 migration is acceptable here.
Migration changes needed by Boot 3, the same diff as #274 / #71 with the parent pinned to the minimum 3.5.12:
javax.persistence/javax.servlet->jakarta.*(domain entities,RequestFilter)SecurityConfig:WebSecurityConfigurerAdapter->SecurityFilterChainbean +DaoAuthenticationProviderbean,@EnableMethodSecurity./error/**/*->/error/**because PathPattern rejects**in the middle. CSRF stays disabled, as on master.mysql:mysql-connector-java->com.mysql:mysql-connector-japplication.properties:spring.main.allow-circular-references=true(UserServiceImpl<->AccountServiceImpl), and the hard-codedMySQL5Dialectis removed (Hibernate 6 detects the dialect itself)AppointmentServiceImpl.findOne->findById(...).orElse(null), JUnit 5 test, Maven wrapper 3.9.9Duplicates: #274 (3.5.16, same CVE, earlier finding), #71 / #62 (3.5.16) and #100-#116 (Boot 4.1.1) also clear this. Only one of them should land. This PR exists because each new finding gets its own PR.
Verification
api.snyk.io, and Boot 3.5.12 is not in the local~/.m2. Somvn testagainst 3.5.12 and the Snyk before/after count could not be run:snyk testfails with SNYK-CLI-0000. Before = 1 issue for this ID (scan finding). After = expected 0, because 3.5.12 managesspring-webmvc6.2.17, the version Snyk lists as fixed. This has not been confirmed by a rescan.new DaoAuthenticationProvider(uds)for its setter form, because that constructor arrived in Security 6.4 (in 3.5.12, not in 3.3.4). Every source file compiles withjavac. The app starts on H2 (MySQL mode). curl flow:POST /signup302 ->POST /index(login) 302 to/userFront->POST /account/deposit302, and the dashboard shows250.00. Anonymous/userFront302s to/index.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/7e227f08e3084ac8a07c70b5a9ebb3ca
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/7e227f08e3084ac8a07c70b5a9ebb3ca?variant=devin
Devin Review