Repository navigation
bug: upgrade Spring Boot 1.5.4 -> 2.2.11.RELEASE (CVE-2022-27772) - #580
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code scan finding
sfind-3dee16a2(Snyk SNYK-JAVA-ORGSPRINGFRAMEWORKBOOT-2438287 / CVE-2022-27772, high, CVSS 7.8). In Boot 1.5.4 the embedded-server temp directory (AbstractConfigurableWebServerFactory.createTempDir) is created world-readable, so it can be hijacked. The finding points atUserFront/pom.xml:30(spring-boot-starter-web).This is a major version bump. 2.2.11.RELEASE is the smallest version that fixes it (
[,2.2.11.RELEASE)is vulnerable), and no 1.5.x release has the fix. Java stays at1.8.Nothing else needed changing. The rest of the code builds as-is on Boot 2.2:
BCryptPasswordEncoderis set explicitly, and Boot 2.2 still allows the app's circularUserServiceImpl/AccountServiceImplbeans (Boot 2.6+ rejects them). The BOM still managesmysql:mysql-connector-java, which becomes 8.0.x.Verification
The session runs with only git access, so Maven Central and
api.snyk.iocouldn't be reached. Because of that:snyk testfails withSNYK-CLI-0000(network). The expected result is that this issue disappears after the change; please re-run the scan to confirm.mvn -o compile/test-compile(JDK 17,java.version1.8): OKUserFrontApplicationTests.contextLoadsrun via JUnitCore againstmysql:5.7:OK (1 test)/, login (POST /index) 302 ->/userFront, deposit 250 shown on/account/primaryAccountand stored inprimary_account, admin/api/appointment/all200, and/api/appointment/{id}/confirm(thefindByIdpath) setsconfirmed=1confirmAppointment, the same asfindOnereturning null on masterDuplicates
Open PR #212 (finding
sfind-b2e00155) makes the same change for the same CVE. Only one of the two should land. Open Boot 2.7/3.x migration PRs (e.g. #173, #229, #71) also clear this CVE.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/13c4db28fbec487d8093d3a17a287295
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/13c4db28fbec487d8093d3a17a287295?variant=devin
Devin Review