Repository navigation
bug: bump auth0-js to ^9.13.2 in AdminPortal (CVE-2020-5263, sfind-171928c8) - #577
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Snyk finding SNYK-JS-AUTH0JS-565004 / CVE-2020-5263 (CWE-522, medium; code-scan finding
sfind-171928c8). In auth0-js versions >=8.0.0 and <9.13.2, the error object from a failed authentication carries the original request, which can include the user's plaintext password.auth0-js@9.13.2.AdminPortal/srcimportsauth0-js(rg auth0matches onlypackage.json), so no app code touches the 8 → 9 API changes.package-lock.jsonisn't committed for AdminPortal, so the manifest is the only file that changes. UserFront and the Java version are untouched.^9.13.2also covers bug: upgrade auth0-js to ^9.3.0 in AdminPortal (CVE-2018-7307) #167 (^9.3.0, CVE-2018-7307).Verification
ng build(Node 12.22.12, JIT, per the repo blueprint) passes: main 35.8 kB, vendor 2.73 MB. Caveat: this build used the existing localnode_modules, which still has auth0-js 8.12.3, because the npm registry is blocked in this session. Since nothing imports auth0-js, the version can't affect the bundle.ng lintreports only errors that already exist onmaster(spacing andprefer-constinsrc/app/**). No files undersrcwere changed.ng testcould not run: Karma 1.7.1 aborts withERROR [karma]: { inspect: [Function: inspect] }before any spec runs. That's an environment problem with the old CLI/Karma and modern Node/Chrome, not something this change causes.snyk test --file=AdminPortal/package.jsonfails withSNYK-CLI-0000because api.snyk.io is unreachable. I requested access to registry.npmjs.org and api.snyk.io, but it hadn't been approved. Expected result: SNYK-JS-AUTH0JS-565004 goes from 1 to 0 for this project, because the declared range now starts at the fixed version 9.13.2. This still needs to be confirmed by a Snyk re-scan.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/f1fd59cbf55945918c4d74e7d0418f74
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/f1fd59cbf55945918c4d74e7d0418f74?variant=devin
Devin Review