Repository navigation
bug: bump embedded Tomcat to 9.0.118 (CVE-2026-43514, AJP secret timing) - #561
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code-scan finding
sfind-34c3ecec/ SNYK-JAVA-ORGAPACHETOMCATEMBED-16643276 (CVE-2026-43514, CWE-208):tomcat-embed-core@8.5.15, which comes in through Boot 1.5.4'sspring-boot-starter-web, compares the AJP secret in non-constant time. The first fixed release is 9.0.118. No 8.5.x release has the fix (8.5 is EOL).<properties> <java.version>1.8</java.version> + <tomcat.version>9.0.118</tomcat.version> </properties>${tomcat.version}fortomcat-embed-core,-el,-websocketandtomcat-jdbc, so this one property moves all of them.Context.addServletMapping(String,String), and Tomcat 9 removed that method. Without a workaround the app fails at startup withNoSuchMethodError. The newconfig/TomcatConfig(EmbeddedServletContainerCustomizer) callssetRegisterDefaultServlet(false). Static files under/staticare still served, because Spring MVC'sResourceHttpRequestHandlerhandles them, not the default servlet.Verification (offline; this session's network allows only the git proxy)
mvn -o maven-dependency-plugin:3.6.1:tree -Dincludes=org.apache.tomcat.embed. It showstomcat-embed-core/-el/-websocket:9.0.118.javac --release 8:TomcatConfig:Unable to start embedded container ... NoSuchMethodError: 'void org.apache.catalina.Context.addServletMapping(java.lang.String, java.lang.String)'TomcatConfig:Tomcat started./pingreturns 200 (9.0.83.0), the app's/css/main.cssreturns 200, and an unknown path returns 404.mvn test/ a full UserFront boot against MySQL. The Boot 1.5.4 parent, the 9.0.118 jars and several 1.5.x starters aren't in the local Maven cache, and Maven Central can't be reached.snyk testfails withSNYK-CLI-0000because api.snyk.io is blocked. Please let the Snyk PR check confirm that the finding clears.Related PRs
Under the one-PR-per-ticket rule this is a new PR. #208 has the identical change (9.0.118 plus
TomcatConfig), and #33, #229 and #230 clear this CVE through a Boot 2.7 upgrade. Only one of these should land.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/286bc615aef147eeb314635436070a99
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/286bc615aef147eeb314635436070a99?variant=devin
Devin Review