Repository navigation
bug: bump embedded Tomcat to 9.0.116 for CVE-2026-29145 (UserFront) - #558
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Snyk
SNYK-JAVA-ORGAPACHETOMCATEMBED-15989808/ CVE-2026-29145 (CWE-287, high, CVSS 8.8): with OCSP soft-fail disabled,CLIENT_CERTOCSP checks intomcat-embed-corecan still soft-fail. UserFront pulls intomcat-embed-core@8.5.15throughspring-boot-starter-web@1.5.4.RELEASE. Code-scan finding:sfind-91366bcec56c4945bcff9e4c5266e26c.<java.version>1.8</java.version> +<tomcat.version>9.0.116</tomcat.version>spring-boot-dependenciessets everytomcat-embed-*,tomcat-jdbcandtomcat-annotations-apiversion from${tomcat.version}. So this one property moves all of them to 9.0.116, the smallest fixed version. There's no 8.5.x fix, so the next options were 10.1.53 or 11.0.20, which need a jakarta/Boot 3 migration.config/TomcatConfigsetssetRegisterDefaultServlet(false). Boot 1.5 registers Tomcat's default servlet throughContext.addServletMapping(String,String), and Tomcat 9 removed that method. Without this change the app dies at startup withNoSuchMethodError. Spring MVC already serves static resources, so the app doesn't need the default servlet.Flag: this is a major bump of the Tomcat line (8.5 → 9.0). Boot 1.5 doesn't officially support Tomcat 9. The default-servlet workaround above is the only incompatibility I found.
Duplicates / overlap (only one should land): #208 uses the same recipe with 9.0.118, which also clears this CVE. #229 and #230 (Boot 2.7.18 + Tomcat 9.0.117/9.0.118) and #33 (also moves to Java 17) clear it as well. #177 (9.0.106) and the 8.5.x pins (#87/#131/#132/#141/#238) do not clear it. I opened this PR anyway because each new finding gets its own PR.
Reachability: UserFront doesn't configure SSL or
CLIENT_CERTauth (there are noserver.ssl.*properties), so the vulnerable OCSP path isn't reachable in the current config. The bump is still the remediation the finding asks for.Verification
I couldn't reach Maven Central or
api.snyk.iofrom this session (network allowlist; access has been requested). That limits what I could check:snyk test --file=UserFront/pom.xmlfails withSNYK-CLI-0000because it can't reach the Snyk API. Please re-run the Snyk scan on this branch to confirm the count drops.mvn compile/mvn teston this exact pom: not run. The 1.5.4 parent, tomcat 9.0.116 and the Security/Thymeleaf 1.5 starters aren't in the local Maven cache. The existingUserFrontApplicationTestsalso needs MySQL plus the full dependency set.spring-boot-dependencies-1.5.8.RELEASE.pom, where everytomcat-embed-*artifact is${tomcat.version}. The 1.5.x line uses the same BOM structure.spring-boot-starter-webapp on the cached tomcat-embed-core 9.0.83 (JDK 11,--release 8):TomcatConfig:Unable to start embedded container; nested exception is java.lang.NoSuchMethodError: 'void org.apache.catalina.Context.addServletMapping(java.lang.String, java.lang.String)'TomcatConfig:Started MiniApp in 1.054 seconds, andGET /indexreturns200(ok 9.0.83.0)Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/aa10e6a2786347f89de2d7800892a694
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/aa10e6a2786347f89de2d7800892a694?variant=devin
Devin Review