Repository navigation
bug: bump AdminPortal auth0-js to ^9.12.0 (crypto-js CVE-2023-46233) - #524
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code-scan finding
sfind-cfb2a2f1(SnykSNYK-JS-CRYPTOJS-6028119/ CVE-2023-46233, high): crypto-js@3.3.0 PBKDF2 defaults to SHA1 with 1 iteration. It reaches AdminPortal throughauth0-js@8.12.3 > idtoken-verifier@1.5.1 > crypto-js@3.3.0.This is the smallest upgrade Snyk lists for this path:
auth0-js@9.12.0 > idtoken-verifier@2.2.4 > crypto-js@4.2.0.auth0-jsis not imported anywhere inAdminPortal/src(grep -rn auth0 srcreturns nothing), so no app code calls it.overridesblock (the approach in bug: override vulnerable crypto-js 3.3.0 with ^4.2.0 in AdminPortal (CVE-2023-46233) #145 / bug: override transitive crypto-js 3.3.0 with 4.2.0 in AdminPortal (SNYK-JS-CRYPTOJS-18599395) #264): the repo blueprint pins Node 12, which ships npm 6.14.16. npm only supportsoverridesfrom 8.3, so npm 6 ignores the block and still installs crypto-js 3.3.0. Raising the direct dependency fixes it on any npm version.Verification
ng build(Node 12.22.12, CLI 1.1.2): passes.auth0-jsisn't in the bundle graph, so the output matches before and after.ng lint: 3 errors (prefer-constinlogin,primary-transactionandsavings-transaction*.component.spec.ts). They are already on master and not in files this PR touches.ng test: Karma 1.7.1 with headless Chrome fails at startup in this VM withERROR [karma]: { inspect: [Function: inspect] }, the same on master. Unit tests did not run.registry.npmjs.organdapi.snyk.ioare blocked in this session (access requested), sosnyk testerrors out. So I have no measured before/after issue count. The finding reports 1 issue on this path (crypto-js@3.3.0 via auth0-js@8.12.3). The fix depends on Snyk's stated upgrade path, which resolves crypto-js@4.2.0 (the fixed version). Please runcd AdminPortal && rm -rf node_modules package-lock.json && npm install && snyk teston Node 12 to confirm.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/271527ec18194ee0947717900e37c0d8
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/271527ec18194ee0947717900e37c0d8?variant=devin
Devin Review