Repository navigation
bug: pin embedded Tomcat to 8.5.99 (CVE-2024-24549) - #477
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…APACHETOMCATEMBED-6435948)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Snyk finding SNYK-JAVA-ORGAPACHETOMCATEMBED-6435948 / CVE-2024-24549 (HTTP/2 header-limit DoS, high, CVSS 7.5) in
org.apache.tomcat.embed:tomcat-embed-core@8.5.15. UserFront gets it transitively fromspring-boot-starter-web(Boot 1.5.4.RELEASE parent).<properties> <java.version>1.8</java.version> + <tomcat.version>8.5.99</tomcat.version> </properties>org.apache.tomcat*artifact offtomcat.version(tomcat-embed-core/-el/-websocket,tomcat-jdbc,tomcat-annotations-api), so they all move 8.5.15 -> 8.5.99.devin/1790739493-tomcat-cve-2024-24549(pins 8.5.100) fixes the same finding. Only one of them should land.Verification
The automation network policy blocks Maven Central and api.snyk.io. Boot 1.5.4 and Tomcat 8.5.99 aren't in the VM's Maven cache, so this exact pom could not be built, the existing tests could not run, and Snyk could not be re-run. I asked for network access; it was still pending when this PR was opened.
[8.5.0,8.5.99), fixed in 8.5.99), this PR clears this finding (1 -> 0 for SNYK-JAVA-ORGAPACHETOMCATEMBED-6435948). Someone with network access still needs to runsnyk test --file=UserFront/pom.xmlto confirm the total count.spring-boot-starter-webapp on JDK 11. With its default Tomcat 8.5.23 jars it serves requests (Starting Servlet Engine: Apache Tomcat/8.5.23). With the newer 8.5.31 jars swapped onto the classpath it also serves requests (Apache Tomcat/8.5.31). That shows Boot 1.5.x runs on a newer Tomcat 8.5 patch release, but 8.5.99 itself was not booted.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/d3eb0ed581874ce89567c74976c5a035
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/d3eb0ed581874ce89567c74976c5a035?variant=devin
Devin Review