Repository navigation
Mitigate CVE-2026-59282 (spring-beans list growth) by rejecting indexed binding paths (sfind-46850d6b) - #469
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…59282 list growth (sfind-46850d6b)
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code scan finding sfind-46850d6b (Snyk SNYK-JAVA-ORGSPRINGFRAMEWORK-19267072, CVE-2026-59282, CWE-770):
spring-beans@4.3.9.RELEASE(via Boot 1.5.4spring-boot-starter-web). Data binding a crafted property path with a huge index can grow a self-populating list until memory runs out.This is a mitigation, not the version bump. Please read this first. The only fixed version is Spring 7.0.9. That needs Boot 4 and Java 17+, and the remediation guidance says "Do not change the Java version" (UserFront stays on
java.version1.8). Spring 7 also isn't available offline in this environment. So this PR blocks the attack path in UserFront instead:Every
@ModelAttributebinder now drops request parameters such asitems[100000000].nameanditems['1'].xbefore they reachBeanWrapper. They show up inBindingResult.getSuppressedFields(). No UserFront template posts indexed field names (checked withgrepforth:field/namecontaining[), and@ModelAttributetargets (User,Recipient,Appointment) only bind scalar fields. Existing forms should behave the same.Duplicate: this is the same change as open PR #155 (sfind-8942cfd6, same CVE). It's a separate PR because of the one-ticket-one-PR rule. Merge only one of them. The real upgrade is the Boot 4.1.1 / Java 21 migration in #100 / #111–#116.
Verification
DataBindingConfigTest(JUnit 4, new): the unhardened binder grows anAutoPopulatingListto 5001 entries (shows the vulnerable behaviour). With the hardened binder, list-index and map-key paths are suppressed and the list stays empty, while plain fields still bind. I compiled it withjavac --release 8and ran it with JUnitCore against cached spring 4.3.12 and 4.3.30 jars:OK (4 tests)on both.mvn testand a Snyk re-scan. The Boot 1.5.4 parent isn't in the local Maven cache, and Maven Central and api.snyk.io are blocked by this session's network policy (snyk test→SNYK-CLI-0000).Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/28cba4a8fd7e47b6b9cddff60cae5985
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/28cba4a8fd7e47b6b9cddff60cae5985?variant=devin
Devin Review