Repository navigation
bug: upgrade UserFront to Spring Boot 3.5.14 (CVE-2026-40975, weak PRNG in ${random.*}) - #458
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…NG behind ${random.*})
Fixes SNYK-JAVA-ORGSPRINGFRAMEWORKBOOT-16191649 (sfind-7890640a). Boot 3.5.14 is the
smallest fixed release; it requires Java 17 and the jakarta namespace, so the
UserFront Java baseline moves from 1.8 to 17.
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CVE-2026-40975 / SNYK-JAVA-ORGSPRINGFRAMEWORKBOOT-16191649 (weak PRNG behind
${random.value},${random.int},${random.long}; CWE-338, high, findingsfind-7890640a) inUserFront/pom.xml. The vulnerablespring-boot@1.5.4.RELEASEcomes in throughspring-boot-starter-web. Fixes exist only in3.5.14and4.0.6, so the parent moves to the smallest of those:The Boot 3 / Spring Security 6 / Hibernate 6 code changes are the same as in PR #178, which this PR cherry-picks:
javax.persistence|servlet.*->jakarta.*(entities,RequestFilter). Ids stayGenerationType.IDENTITY.SecurityConfig:WebSecurityConfigurerAdapter->SecurityFilterChainbean +DaoAuthenticationProvider(userSecurityService)./error/**/*->/error/**, because PathPatternParser rejects the old pattern. URL rules, form login, logout and remember-me stay the same.application.properties: addsspring.main.allow-circular-references=true(UserServiceImpl <-> AccountServiceImpl) and drops theMySQL5Dialectoverride.Duplicate note: open PR #178 (CVE-2026-40977) has the identical diff and also clears this CVE. So do #71 / #62 (3.5.16) and the #100-#116 series (4.1.1). This PR was opened because each finding gets its own PR. Only one of them should be merged.
Verification (the session's network allowlist only reaches
git-manager.devin.ai; Maven Central and api.snyk.io access was requested but not yet granted)snyk test --file=UserFront/pom.xmlfails withSNYK-CLI-0000, because api.snyk.io can't be reached. Expected result: SNYK-JAVA-ORGSPRINGFRAMEWORKBOOT-16191649 disappears, becausespring-bootresolves to 3.5.14. Please confirm in Snyk or CI.mvn compile/mvn teston the real 3.5.14 parent. It isn't in~/.m2, Maven Central is blocked, andmvn testalso needs MySQL.DaoAuthenticationProviderconstructor exists only in Security 6.4+, so I used the setter form there.mvn -o test-compilesucceeds. I then booted the app on H2 (MySQL mode) and checked it over HTTP:Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/0e8ab947eb234e09835117d9817c6b66
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/0e8ab947eb234e09835117d9817c6b66?variant=devin
Devin Review