Repository navigation
bug: upgrade mysql-connector-java to 8.0.13 (CVE-2018-3258) #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
devin-ai-integration
wants to merge
1
commit into
master
Choose a base branch
from
devin/sfind-e7a6cbbd-mysql-connector-cve-2018-3258
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Database startup fails in CEST
When MySQL reports
CEST, the upgraded connector rejectsspring.datasource.urlwithout aserverTimezonesetting. Database initialization fails, leaving the banking frontend unavailable.Learn more
Connector/J 8.0.13 resolves the MySQL server's timezone when opening a connection. The configured datasource URL has no
serverTimezonevalue. If the server reports an abbreviation such asCEST, this connector does not recognize it and rejects the connection. The application's JPA startup needs that connection, so the frontend cannot start in that deployment.Example: A MySQL instance reports
@@system_time_zone = CESTwhile the URL remainsjdbc:mysql://localhost:3306/onlinebanking. Connector/J 8.0.13 rejects the connection rather than loading the banking accounts.Recommended fix: Set
serverTimezoneto the deployment's correct IANA timezone in the datasource URL or ensure MySQL reports a recognized timezone. Verify connection startup against a server configured with an abbreviated timezone before deploying the upgrade.Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. This is a known Connector/J 8.0.0–8.0.22 behaviour, and the PR description already flags it. I couldn't reproduce it here because the 8.0.13 jar isn't cached and Maven Central is blocked. The local MySQL 5.7 reports
@@system_time_zone = UTC, so it isn't affected.I've left the change as is because the correct fix depends on how this is deployed:
?serverTimezone=<IANA zone>tospring.datasource.url. This needs to be the zone the DB actually runs in. HardcodingUTCwould silently shift storedDates on a non-UTC server. Under 5.1.x, by default, timestamps were sent without any conversion.connectionTimeZone=LOCAL, which matches 5.1's no-conversion behaviour and doesn't fail onCEST. It goes past the "smallest fixing version" rule, though.Maintainers: tell me which option you want and I'll push it.