Repository navigation
bug: upgrade auth0-js to ^9.3.0 in AdminPortal (CVE-2018-7307) - #433
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Snyk
npm:auth0-js:20180226/ CVE-2018-7307 (CSRF: authorization response with nostatewas accepted; high, CVSS 7.5), code-scan findingsfind-2256ec41, inAdminPortal/package.json:24.9.3.0is the smallest fixed version, as Snyk recommends. This is a major bump (8 -> 9).auth0-jsisn't imported anywhere inAdminPortal/srcor the CLI config, so no app code needs to change.^8.8.0can resolve to a vulnerable version (<9.3.0);^9.3.0cannot.Duplicates: open PR #167 makes the same change for an earlier ticket (sfind-1a21a3aa). PR #237 (
^9.13.2, which also clears CVE-2020-5263) and #269 (^10.0.0) cover this CVE too. This PR was opened for the new finding, as the one-PR-per-ticket rule requires. Only one of them should land.Verification
ng build(Angular CLI 1.1.2, Node 12.22.12) passes with the existingnode_modules.ng lintreports 3 errors (prefer-constin*.component.spec.ts). They are on master already and unrelated to this change.auth0-jsis8.12.3, so the finding count is 1. Checked withsemver.satisfies("8.12.3", "<9.3.0") === true.semver.intersects("^9.3.0", "<9.3.0") === false, so the expected count is 0.npm installof 9.x and the Snyk rescan. registry.npmjs.org and api.snyk.io are blocked in this session; access was requested but not granted. The before/after counts above are worked out from semver, not taken from a Snyk run.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/9867c3c9d54f4c3d8dd1fc466557f7f2
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/9867c3c9d54f4c3d8dd1fc466557f7f2?variant=devin
Devin Review