Repository navigation
bug: upgrade tomcat-embed-core to 9.0.117 for CVE-2026-34483 (Spring Boot 1.5.4 -> 2.7.18) - #412
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ot 1.5.4 -> 2.7.18)
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes code-scan finding
sfind-b6f3745f/ SNYK-JAVA-ORGAPACHETOMCATEMBED-15989812 (CVE-2026-34483,JsonAccessLogValveJSON escaping, CWE-116, medium) onUserFront/pom.xml.tomcat-embed-corewas 8.5.15, pulled in by Boot 1.5.4.This is a major bump. Please review it as one. The earliest fixed version is 9.0.117, and no fixed 8.5.x exists because 8.5 is EOL. Boot 1.5 can't run Tomcat 9: you get
NoSuchMethodError Context.addServletMappingat startup. So the parent has to go to the last Boot 2.x line. The Java version is unchanged (java.version1.8).parent spring-boot-starter-parent 1.5.4.RELEASE -> 2.7.18 +<tomcat.version>9.0.117</tomcat.version> (2.7.18 ships 9.0.83; this pins the smallest fixed version) mysql:mysql-connector-java -> com.mysql:mysql-connector-j (renamed coordinates in Boot 2.7)Boot 2.x compatibility changes, with no behaviour change intended:
AppointmentServiceImpl.findAppointment:findOne(id)->findById(id).orElse(null)(Spring Data 2.x).SecurityConfig: the@Autowired configureGlobal(AuthenticationManagerBuilder)method is now@Override configure(AuthenticationManagerBuilder). This keeps the sameuserSecurityService+ BCrypt setup.application.properties:spring.main.allow-circular-references=true, becauseUserServiceImplandAccountServiceImplinject each other and Boot 2.6+ rejects that by default. Alsospring.jpa.hibernate.use-new-id-generator-mappings=false, which keepsGenerationType.AUTOon MySQL auto-increment as in Boot 1.x, so existing schemas still work.UserFrontApplicationTests: JUnit 4SpringRunner-> JUnit 5.Duplicate: open PR #272 has the identical change for this same CVE (#229 is the same recipe for CVE-2026-34500; #33 and others pin 9.0.118 but also change the Java version). Only one of these should land. This PR exists because each new scan finding gets its own PR.
Verification
The session only had git access (Maven Central and api.snyk.io were blocked), so I used stand-ins:
mvn -o dependency:tree -Dincludes=org.apache.tomcat.embedresolvestomcat-embed-core/-el/-websocket:9.0.117underspring-boot-starter-tomcat:2.7.18.-Dtomcat.version=9.0.83:mvn -o test-compile(JDK 17, target 1.8) passes.UserFrontApplicationon Boot 2.7.18 / Tomcat 9.0.83 against MySQL 5.7, then ran sign-up, login, a $125 deposit and an anonymous request:primary_account.account_balance = 125.00, with aprimary_transactionrow (Account,125,Finished)./userFrontrequest redirected to/index.snyk testfails with SNYK-CLI-0000 because the network is restricted. Expected from the advisory ranges: this issue goes 1 -> 0, since 9.0.117 is outside[,9.0.117).mvn testwith the real 9.0.117 jars, and a Snyk rescan. Both need network access.Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/eb715c08a49a42de9c07c649e8625202
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/eb715c08a49a42de9c07c649e8625202?variant=devin