Repository navigation
bug: disable Spring Data web support to mitigate CVE-2026-41721 (spring-data-commons DoS, sfind-72af087c) - #384
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ding DoS path (sfind-72af087c)
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Finding
sfind-72af087c/ SNYK-JAVA-ORGSPRINGFRAMEWORKDATA-17279540 (CVE-2026-41721, CVSS 8.2, CWE-400).UserFrontgetsspring-data-commons@1.13.4.RELEASEthroughspring-boot-starter-data-jpa(Boot 1.5.4).This PR mitigates the issue. It does not upgrade the dependency. Snyk lists fixes only in
3.5.12and4.0.6, with nothing on the 1.x or 2.x lines. Spring Data Commons 3.5.x needs Boot 3, Spring 6 and Java 17 (javax -> jakarta). The remediation guidance says "do not change the Java version" (1.8), so the smallest version that clears the finding would be a major, Java-changing migration. That needs a human decision.The advisory says the bug is exploitable only when Spring Data Web Support is enabled and a controller binds a
@ProjectedPayload(ProxyingHandlerMethodArgumentResolver). Boot turns web support on automatically throughSpringDataWebAutoConfiguration. UserFront never uses it: it has noPageable,Sort,@ProjectedPayloador interface-typed handler params. This PR switches it off:That removes the
Sort,PageableandProxyingMVC argument resolvers, so the vulnerable binding path can't be reached. JPA repositories are not affected.Duplicate notice: this change is identical to open PR #197 (an earlier trigger of the same CVE,
sfind-da6c33d2). It was opened separately under the one-finding-one-PR rule. Only one of #197 and this PR should land.Verification
mvn compileormvn test. The Boot1.5.4.RELEASEparent and the thymeleaf/security/mysql starters aren't in the local Maven cache, and Maven Central is blocked in this session.UserFront/src/testcontains no tests.UserFrontApplication.javacompiles against the Boot 1.5.8 classpath.@ProjectedPayload interface Formparameter, and I sentPOST /p -d name=aliceto it:@SpringBootApplicationbound:alice via com.sun.proxy.$Proxy76: the projection proxy is bound, so the vulnerable path is reachable@SpringBootApplication(exclude = SpringDataWebAutoConfiguration.class)500 BeanInstantiationException: ... Specified class is an interface: no projecting resolver is registeredsnyk test --file=UserFront/pom.xmlfails withSNYK-CLI-0000because the session's network allowlist blocks api.snyk.io. Expected count is 1 -> 1 for this issue, because the dependency version doesn't change. I added no Snyk ignore and changed no thresholds.Actual upgrade paths (all change Java)
If one of those lands, this exclusion can stay as defense in depth or be reverted.
Devin-Org: engineering
Link to Devin session: https://devin-gtm.devinenterprise.com/sessions/62b85211e98e4a069b18edf9ebead0e7
Open in Devin Desktop: https://devin-gtm.devinenterprise.com/desktop/session/62b85211e98e4a069b18edf9ebead0e7?variant=devin