Repository navigation
COG-1152: SecurityConfig hygiene + widen password encoder bean to PasswordEncoder - #337
Open
patrickbradley-cog wants to merge 1 commit into
Conversation
…n to PasswordEncoder Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear: COG-1152 — W1 forward-compatible refactor on Boot 1.5.4 (no Boot/Java bump).
SecurityConfig:UserServiceImpl: fieldBCryptPasswordEncoder passwordEncoder→PasswordEncoder passwordEncoder(import swapped;encode()call unchanged).Why the bean type matters: Spring registers
@Beanmethods under the declared return type. W2 declaresPasswordEncoder passwordEncoder(), which would not satisfy a concreteBCryptPasswordEncoderinjection point →NoSuchBeanDefinitionExceptionat startup. Decoupling now keeps the W2 pivot structural-only.Behaviour notes:
/error/**matches the same paths under today'sAntPathMatcher;/errorstays permitted./console/**now requires auth (anonymous → 302/index) instead of an anonymous 404.$2a$12$…rows still verify (verified below).Merge order: should merge behind the W0 smoke suite (#106, #108, #109). COG-1159 also edits
PUBLIC_MATCHERS; this PR's edit to the array is a 2-line → 1-line change so the second to merge rebases trivially.Verification
JDK: Temurin
1.8.0_504; MySQL 5.7 in docker (useSSL=falseoverride needed because modern JDK 8 disables TLSv1/1.1 used by Connector/J 5.1.42 — environment only, not changed in repo).SPRING_DATASOURCE_URL='jdbc:mysql://localhost:3306/onlinebanking?useSSL=false' mvn -B -f UserFront/pom.xml verifyPre-existing hash compatibility — user created by the
masterbuild, then logged in with this branch's build:New hash via widened
PasswordEncoderfield (branch jar, fresh DB):Matchers (anonymous, branch jar):
Unrelated pre-existing issue observed (not touched here): a second signup after an app restart fails with
NonUniqueResultExceptioninAccountServiceImpl.createPrimaryAccountbecauseaccountGen()restarts its counter per JVM; that's why the new-hash check used a fresh DB. Smoke suite not run (not onmasteryet).Link to Devin session: https://app.devin.ai/sessions/cbd67468fca14ee6928abaec5893378c
Open in Devin Desktop: https://app.devin.ai/desktop/session/cbd67468fca14ee6928abaec5893378c?variant=devin
Requested by: @patrickbradley-cog
Devin Review