Skip to content

COG-1161: W1 · Drop the redundant spring-boot-starter-jdbc dependency - #331

Open
patrickbradley-cog wants to merge 1 commit into
masterfrom
devin/cog-1161-w1-drop-the-redundant-spring-boot-starter-jdbc-dependency
Open

patrickbradley-cog wants to merge 1 commit into
masterfrom
devin/cog-1161-w1-drop-the-redundant-spring-boot-starter-jdbc-dependency

Conversation

@patrickbradley-cog

@patrickbradley-cog patrickbradley-cog commented Sep 30, 2026 •

Copy link
Copy Markdown

Summary

Linear: COG-1161 — W1 · Drop the redundant spring-boot-starter-jdbc dependency

Removes the explicit spring-boot-starter-jdbc <dependency> from UserFront/pom.xml. spring-boot-starter-data-jpa already pulls it in transitively, so the resolved classpath is unchanged — the starter just moves from a direct to a transitive edge. Nothing else in the pom changes (parent bump / starter rename / driver swap stay in their own wave pivots). W1 forward-compatible refactor on Boot 1.5.4; Boot/Java not bumped.

Merge order: should merge behind the W0 smoke suite (#106, #108, #109) once that is green, and before the W2 pom pivot.

Verification (JDK Temurin 1.8.0_504, Maven, MySQL 5.7 in docker)

mvn dependency:tree — before vs after

Only the position of spring-boot-starter-jdbc changes (direct -> under spring-boot-starter-data-jpa); tomcat-jdbc 8.5.15 and spring-jdbc 4.3.9 are still present. Flattened + sorted, the resolved artifact set is identical (80 artifacts).

$ diff deptree-before.txt deptree-after.txt
36,40d35
< +- org.springframework.boot:spring-boot-starter-jdbc:jar:1.5.4.RELEASE:compile
< |  +- org.apache.tomcat:tomcat-jdbc:jar:8.5.15:compile
< |  |  \- org.apache.tomcat:tomcat-juli:jar:8.5.15:compile
< |  \- org.springframework:spring-jdbc:jar:4.3.9.RELEASE:compile
< |     \- org.springframework:spring-tx:jar:4.3.9.RELEASE:compile
43a39,42
> |  +- org.springframework.boot:spring-boot-starter-jdbc:jar:1.5.4.RELEASE:compile
> |  |  +- org.apache.tomcat:tomcat-jdbc:jar:8.5.15:compile
> |  |  |  \- org.apache.tomcat:tomcat-juli:jar:8.5.15:compile
> |  |  \- org.springframework:spring-jdbc:jar:4.3.9.RELEASE:compile
55a55
> |  |  +- org.springframework:spring-tx:jar:4.3.9.RELEASE:compile
$ diff <(flatten before) <(flatten after) && echo identical
RESOLVED SET IDENTICAL (80 artifacts)

mvn -B -f UserFront/pom.xml verify

Started UserFrontApplicationTests in 2.721 seconds
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
[INFO] Building jar: .../UserFront/target/userFront-0.0.1-SNAPSHOT.jar
[INFO] BUILD SUCCESS

Run with -Dspring.datasource.url=jdbc:mysql://localhost:3306/onlinebanking?useSSL=false. Without useSSL=false the context test fails identically on unmodified master (verified, BUILD FAILURE with the same cause): the bundled mysql-connector-java 5.1.42 negotiates TLSv1/1.1, which current JDK 8 builds disable (SSLHandshakeException: No appropriate protocol). Environmental, pre-existing, and out of scope here (driver swap is its own pivot).

Manual flow against MySQL (packaged jar, datasource pool = tomcat-jdbc via transitive starter)

Seeded role with ROLE_USER/ROLE_ADMIN (app expects them to exist), then:

== signup                         302 -> http://localhost:8080/
== login                          302 -> http://localhost:8080/userFront
== deposit 250 primary            302 -> http://localhost:8080/userFront
== transfer 100 primary->savings  302 -> http://localhost:8080/userFront
username  primary_bal  savings_bal
cog1161   150.00       100.00
description                                        type     status    amount  available_balance
Deposit to Primary Account                         Account  Finished  250     250.00
Between account transfer from Primary to Savings   Account  Finished  100     150.00

No CI workflows exist in this repo, so there is no CI run to report.

Devin-Org: engineering

Link to Devin session: https://app.devin.ai/sessions/a9f309c887cf4280af8f5f3679099371
Open in Devin Desktop: https://app.devin.ai/desktop/session/a9f309c887cf4280af8f5f3679099371?variant=devin
Requested by: @patrickbradley-cog


Devin Review

Status Commit
⚪ Not started —

Run Devin Review

Devin Review (Staging)


Devin Review

spring-boot-starter-data-jpa already brings spring-boot-starter-jdbc
(spring-jdbc + tomcat-jdbc) transitively.

Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant