Repository navigation
COG-1161: W1 · Drop the redundant spring-boot-starter-jdbc dependency - #331
Open
patrickbradley-cog wants to merge 1 commit into
Open
patrickbradley-cog wants to merge 1 commit into
patrickbradley-cog wants to merge 1 commit into
Conversation
spring-boot-starter-data-jpa already brings spring-boot-starter-jdbc (spring-jdbc + tomcat-jdbc) transitively. Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear: COG-1161 — W1 · Drop the redundant spring-boot-starter-jdbc dependency
Removes the explicit
spring-boot-starter-jdbc<dependency>fromUserFront/pom.xml.spring-boot-starter-data-jpaalready pulls it in transitively, so the resolved classpath is unchanged — the starter just moves from a direct to a transitive edge. Nothing else in the pom changes (parent bump / starter rename / driver swap stay in their own wave pivots). W1 forward-compatible refactor on Boot 1.5.4; Boot/Java not bumped.Merge order: should merge behind the W0 smoke suite (#106, #108, #109) once that is green, and before the W2 pom pivot.
Verification (JDK Temurin 1.8.0_504, Maven, MySQL 5.7 in docker)
mvn dependency:tree— before vs afterOnly the position of
spring-boot-starter-jdbcchanges (direct -> underspring-boot-starter-data-jpa);tomcat-jdbc8.5.15 andspring-jdbc4.3.9 are still present. Flattened + sorted, the resolved artifact set is identical (80 artifacts).mvn -B -f UserFront/pom.xml verifyRun with
-Dspring.datasource.url=jdbc:mysql://localhost:3306/onlinebanking?useSSL=false. WithoutuseSSL=falsethe context test fails identically on unmodifiedmaster(verified,BUILD FAILUREwith the same cause): the bundledmysql-connector-java5.1.42 negotiates TLSv1/1.1, which current JDK 8 builds disable (SSLHandshakeException: No appropriate protocol). Environmental, pre-existing, and out of scope here (driver swap is its own pivot).Manual flow against MySQL (packaged jar, datasource pool = tomcat-jdbc via transitive starter)
Seeded
rolewithROLE_USER/ROLE_ADMIN(app expects them to exist), then:No CI workflows exist in this repo, so there is no CI run to report.
Devin-Org: engineering
Link to Devin session: https://app.devin.ai/sessions/a9f309c887cf4280af8f5f3679099371
Open in Devin Desktop: https://app.devin.ai/desktop/session/a9f309c887cf4280af8f5f3679099371?variant=devin
Requested by: @patrickbradley-cog
Devin Review