Repository navigation
COG-1157: UserController + AppointmentController @RequestMapping → @GetMapping/@PostMapping - #330
Open
patrickbradley-cog wants to merge 1 commit into
Conversation
…od) -> @GetMapping/@PostMapping Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear: COG-1157 — W1 forward-compatible refactor on Boot 1.5.4 (no Boot/Java bump). Annotation-only diff in
UserControllerandAppointmentController:@RequestMapping("/user")/@RequestMapping("/appointment")prefixes are kept (so theRequestMappingimport stays).profile.htmlposts to/user/profile,appointment.htmlposts to/appointment/create,header.htmllinks GET to both.)AppointmentControllerSimpleDateFormat("yyyy-MM-dd hh:mm").parse(date)block left untouched (owned by the W5LocalDateTimeticket).HomeController(/signup), which belongs to the sibling controller ticket. The appointment-create and profile flows are the ones exercised here.Merge order: should merge behind the W0 smoke suite (COG-1141 harness, PRs #106/#108/#109) once that's green. Not merged by this session.
Verification
JDK: Temurin 8 (
1.8.0), MySQL 5.7 in Docker (onlinebankingdb, repo's default creds). Modern JDK 8 disables TLSv1/1.1, which breaks Connector/J 5.1's default SSL handshake with MySQL 5.7, so the datasource URL was overridden with?useSSL=falseon the command line only — no repo config changed.Handler mappings registered at startup are unchanged in shape:
Ran the jar against MySQL and exercised the flows with curl (fresh DB needs the
roleseed rows — pre-existing requirement, unrelated to this change):Link to Devin session: https://app.devin.ai/sessions/5c6402db48534194839f69d12cefced2
Open in Devin Desktop: https://app.devin.ai/desktop/session/5c6402db48534194839f69d12cefced2?variant=devin
Requested by: @patrickbradley-cog
Devin Review