Skip to content

COG-1149: W0 · GitHub Actions workflow running mvn verify on every PR - #329

Open
patrickbradley-cog wants to merge 3 commits into
masterfrom
devin/cog-1149-w0-github-actions-workflow-running-mvn-verify-on-every-pr
Open

patrickbradley-cog wants to merge 3 commits into
masterfrom
devin/cog-1149-w0-github-actions-workflow-running-mvn-verify-on-every-pr

Conversation

@patrickbradley-cog

@patrickbradley-cog patrickbradley-cog commented Sep 30, 2026 •

Copy link
Copy Markdown

Summary

COG-1149 — https://linear.app/cog-gtm/issue/COG-1149/w0-github-actions-workflow-running-mvn-verify-on-every-pr

Adds .github/workflows/userfront-ci.yml so every PR in the Boot 1.5.4 → 4.1 wave is gated by CI.

  • Actions pinned to Node-24 majors (checkout@v5, setup-java@v5, setup-node@v5, upload-artifact@v6) to avoid the Node 20 deprecation.
  • Triggers: pull_request (any base), push to master/main, workflow_dispatch. concurrency cancels superseded runs per ref.
  • userfront-verify (blocking): actions/setup-java@v5 Temurin 8 (matches <java.version>1.8</java.version>; W3 bumps both to 21) with cache: maven → mvn -B -f UserFront/pom.xml verify. On failure, uploads UserFront/target/surefire-reports/ (+ failsafe) as artifact userfront-surefire-reports. No services: mysql and no test skipping — the Testcontainers harness from COG-1141 will use the runner's Docker.
  • adminportal-build (non-blocking, continue-on-error: true): Angular CLI 1.1.2 / Angular 4 needs legacy Node 12 (actions/setup-node@v5). AdminPortal has no package-lock.json committed, so the step runs npm ci if a lockfile exists and falls back to npm install otherwise; then npm run build.

Expected CI state on this PR

userfront-verify will be red until COG-1141 (Testcontainers harness) merges: today UserFrontApplicationTests.contextLoads() needs a live MySQL at localhost:3306, which CI intentionally does not provide. The failure is at the test phase (compile succeeds), i.e. the workflow itself is correct. Once COG-1141 is on master, this job goes green with no workflow change.

CI evidence

  • This PR, runs on e2704a8 / 449843a / f28c095: UserFront · mvn verify compiles 37 main + 1 test source, reaches surefire, fails only on UserFrontApplicationTests.contextLoads » IllegalState caused by CommunicationsException: Communications link failure (no MySQL); the userfront-surefire-reports artifact is uploaded on failure as intended. AdminPortal · ng build (non-blocking): success.
  • Throwaway branch (deleted after the run; identical workflow except -DskipTests + push trigger on that branch): https://github.com/COG-GTM/Online-Banking-with-Java-Spring-Boot-Angular-2/actions/runs/36743023311 — both jobs green (Tests are skipped → repackage → BUILD SUCCESS). The committed workflow does not skip tests.

Local verification (same commands the workflow runs)

Temurin 1.8.0_504, Maven 3.6.3.

  1. No DB (what CI sees today) — mvn -B -f UserFront/pom.xml verify → compiles, reaches surefire, contextLoads fails with CommunicationsException: Communications link failure → BUILD FAILURE.
  2. Throwaway mysql:5.7 on :3306 (onlinebanking db) — mvn -B -f UserFront/pom.xml verify "-Dspring.datasource.url=jdbc:mysql://localhost:3306/onlinebanking?useSSL=false":
    Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
    [INFO] Building jar: .../UserFront/target/userFront-0.0.1-SNAPSHOT.jar
    [INFO] --- spring-boot-maven-plugin:1.5.4.RELEASE:repackage (default) @ userFront ---
    [INFO] BUILD SUCCESS
    
    (useSSL=false only because modern JDK 8 disables TLS 1.0/1.1 that Connector/J 5.1.42 negotiates with MySQL 5.7 — relevant to COG-1141, not this workflow.)
  3. AdminPortal on Node 12.22.12 — npm install && npm run build → ng build emits inline/polyfills/styles/vendor/main bundles, exit 0.

Link to Devin session: https://app.devin.ai/sessions/f963b00da023498e87ab45bbc961e2f2
Open in Devin Desktop: https://app.devin.ai/desktop/session/f963b00da023498e87ab45bbc961e2f2?variant=devin
Requested by: @patrickbradley-cog


Devin Review

Status Commit
⚪ Not started —

Run Devin Review

Devin Review (Staging)

Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
@devin-ai-integration

Copy link
Copy Markdown

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

devin-ai-integration Bot and others added 2 commits September 30, 2026 16:16
Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant