Repository navigation
COG-1149: W0 · GitHub Actions workflow running mvn verify on every PR - #329
Open
patrickbradley-cog wants to merge 3 commits into
Open
patrickbradley-cog wants to merge 3 commits into
patrickbradley-cog wants to merge 3 commits into
Conversation
Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
Co-Authored-By: patrick.bradley <patrick.bradley@cognition.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COG-1149 — https://linear.app/cog-gtm/issue/COG-1149/w0-github-actions-workflow-running-mvn-verify-on-every-pr
Adds
.github/workflows/userfront-ci.ymlso every PR in the Boot 1.5.4 → 4.1 wave is gated by CI.checkout@v5,setup-java@v5,setup-node@v5,upload-artifact@v6) to avoid the Node 20 deprecation.pull_request(any base),pushtomaster/main,workflow_dispatch.concurrencycancels superseded runs per ref.userfront-verify(blocking):actions/setup-java@v5Temurin 8 (matches<java.version>1.8</java.version>; W3 bumps both to 21) withcache: maven→mvn -B -f UserFront/pom.xml verify. On failure, uploadsUserFront/target/surefire-reports/(+ failsafe) as artifactuserfront-surefire-reports. Noservices: mysqland no test skipping — the Testcontainers harness from COG-1141 will use the runner's Docker.adminportal-build(non-blocking,continue-on-error: true): Angular CLI 1.1.2 / Angular 4 needs legacy Node 12 (actions/setup-node@v5).AdminPortalhas nopackage-lock.jsoncommitted, so the step runsnpm ciif a lockfile exists and falls back tonpm installotherwise; thennpm run build.Expected CI state on this PR
userfront-verifywill be red until COG-1141 (Testcontainers harness) merges: todayUserFrontApplicationTests.contextLoads()needs a live MySQL atlocalhost:3306, which CI intentionally does not provide. The failure is at the test phase (compile succeeds), i.e. the workflow itself is correct. Once COG-1141 is onmaster, this job goes green with no workflow change.CI evidence
UserFront · mvn verifycompiles 37 main + 1 test source, reaches surefire, fails only onUserFrontApplicationTests.contextLoads » IllegalStatecaused byCommunicationsException: Communications link failure(no MySQL); theuserfront-surefire-reportsartifact is uploaded on failure as intended.AdminPortal · ng build (non-blocking): success.-DskipTests+ push trigger on that branch): https://github.com/COG-GTM/Online-Banking-with-Java-Spring-Boot-Angular-2/actions/runs/36743023311 — both jobs green (Tests are skipped→repackage→BUILD SUCCESS). The committed workflow does not skip tests.Local verification (same commands the workflow runs)
Temurin
1.8.0_504, Maven 3.6.3.mvn -B -f UserFront/pom.xml verify→ compiles, reaches surefire,contextLoadsfails withCommunicationsException: Communications link failure→BUILD FAILURE.mysql:5.7on :3306 (onlinebankingdb) —mvn -B -f UserFront/pom.xml verify "-Dspring.datasource.url=jdbc:mysql://localhost:3306/onlinebanking?useSSL=false":useSSL=falseonly because modern JDK 8 disables TLS 1.0/1.1 that Connector/J 5.1.42 negotiates with MySQL 5.7 — relevant to COG-1141, not this workflow.)npm install && npm run build→ng buildemitsinline/polyfills/styles/vendor/mainbundles, exit 0.Link to Devin session: https://app.devin.ai/sessions/f963b00da023498e87ab45bbc961e2f2
Open in Devin Desktop: https://app.devin.ai/desktop/session/f963b00da023498e87ab45bbc961e2f2?variant=devin
Requested by: @patrickbradley-cog
Devin Review